Skip to content

Bug 1953127: UPSTREAM: <drop>: work around broken NetPol DNS rules#770

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:fix-netpol-dns
Jun 3, 2021
Merged

Bug 1953127: UPSTREAM: <drop>: work around broken NetPol DNS rules#770
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:fix-netpol-dns

Conversation

@danwinship
Copy link

@danwinship danwinship commented May 25, 2021

The tests assume that the DNS pods listen on port 53, which they don't in OCP. Hack around this for now. kubernetes#102286 should result in an eventual fix.

/cc @aojea

@danwinship
UPSTREAM: <drop>: work around broken NetPol DNS rules
8981aab 
The tests assume that the DNS pods listen on port 53, which they don't
in OCP. Hack around this for now.
kubernetes#102286 should result
in an eventual fix.
@openshift-ci openshift-ci bot requested a review from aojea May 25, 2021 12:38
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 25, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 25, 2021

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci
Copy link

openshift-ci bot commented May 25, 2021

@danwinship: This pull request references Bugzilla bug 1953127, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

Bug 1953127: UPSTREAM: : work around broken NetPol DNS rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 25, 2021
@openshift-ci openshift-ci bot requested a review from zhaozhanqi May 25, 2021 12:38
@aojea
Copy link

aojea commented May 25, 2021

I remember you've already fixed the old tests
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@danwinship
Copy link
Author

danwinship commented May 26, 2021

/assign @soltysh
/retest

ugly hack, but it works (openshift/origin#26182) and will be fixed better upstream by 1.22 (kubernetes#102286)

@abhat
Copy link

abhat commented May 27, 2021

/test k8s-e2e-gcp

soltysh
soltysh approved these changes Jun 2, 2021
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh soltysh removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 2, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, danwinship, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@openshift-bot
Copy link

openshift-bot commented Jun 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link

openshift-bot commented Jun 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bee5ae2 into openshift:master Jun 3, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2021

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 1953127 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1953127: UPSTREAM: : work around broken NetPol DNS rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship mentioned this pull request Jun 3, 2021
Closed
@openshift-ci openshift-ci bot mentioned this pull request Jun 22, 2021
Merged
@danwinship danwinship deleted the fix-netpol-dns branch November 19, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@aojea aojea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@danwinship @openshift-ci-robot @aojea @abhat @openshift-bot @soltysh @openshift-merge-robot