[sdn-4.5-kubernetes-1.18.2] Bug 1935297: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service #604

openshift-cherrypick-robot · 2021-03-04T15:14:18Z

This is an automated cherry-pick of #581

/assign Miciah

Kube-proxy now prefers the node-local DNS pod, if one exists, for the cluster DNS service.

This commit fixes bug 1919737. https://bugzilla.redhat.com/show_bug.cgi?id=1919737 * pkg/proxy/iptables/proxier.go (syncProxyRules): Prefer a local endpoint for the cluster DNS service.

openshift-ci-robot · 2021-03-04T15:14:23Z

@openshift-cherrypick-robot: Could not make automatic cherrypick of Bugzilla bug 1928773 for this PR as the target_release is not set for this branch in the bugzilla plugin config. Running refresh:
/bugzilla refresh

Details

In response to this:

[sdn-4.5-kubernetes-1.18.2] [sdn-4.6-kubernetes-1.18.6] Bug 1928773: UPSTREAM: : Prefer local endpoint for cluster DNS service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-03-04T15:14:26Z

@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

a18cff1|UPSTREAM: : Prefer local endpoint for cluster DNS service: does not specify an upstream backport in the commit message

openshift-ci-robot · 2021-03-04T15:14:39Z

@openshift-ci-robot: This pull request references Bugzilla bug 1928773, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1928304 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
bug has dependents

Details

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Bugzilla bug 1928773 for this PR as the target_release is not set for this branch in the bugzilla plugin config. Running refresh:
/bugzilla refresh

In response to this:

[sdn-4.5-kubernetes-1.18.2] [sdn-4.6-kubernetes-1.18.6] Bug 1928773: UPSTREAM: : Prefer local endpoint for cluster DNS service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2021-03-04T15:31:23Z

/bugzilla refresh

openshift-ci-robot · 2021-03-04T15:31:26Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1935297, which is invalid:

expected dependent Bugzilla bug 1928773 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[sdn-4.5-kubernetes-1.18.2] Bug 1935297: UPSTREAM: : Prefer local endpoint for cluster DNS service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-03-04T15:31:28Z

@Miciah: This pull request references Bugzilla bug 1935297, which is invalid:

expected dependent Bugzilla bug 1928773 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2021-03-05T16:25:20Z

openshift/sdn#268 pass CI, so this PR should be safe to merge.

aojea · 2021-03-05T19:01:38Z

/lgtm

openshift-bot · 2021-03-06T01:01:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-06T01:01:18Z

@openshift-bot: This pull request references Bugzilla bug 1935297, which is invalid:

expected dependent Bugzilla bug 1928773 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-07T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-07T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 1935297, which is invalid:

expected dependent Bugzilla bug 1928773 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-08T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-08T01:01:13Z

@openshift-bot: This pull request references Bugzilla bug 1935297, which is invalid:

expected dependent Bugzilla bug 1928773 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-09T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-09T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 1935297, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1928773 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knobunc · 2021-03-11T14:05:33Z

/approve

deads2k · 2021-03-11T14:12:08Z

/approve

deads2k · 2021-03-11T14:12:50Z

removed the commit check. this is networking's branch and Ben Bennett acked the change.

openshift-ci-robot · 2021-03-11T14:27:11Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: aojea, deads2k, knobunc, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2021-03-11T14:42:24Z

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-dns-operator#242 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1935297 has not been moved to the MODIFIED state.

Details

In response to this:

[sdn-4.5-kubernetes-1.18.2] Bug 1935297: UPSTREAM: : Prefer local endpoint for cluster DNS service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2021-03-17T17:41:52Z

/cherry-pick sdn-4.4-kubernetes-1.17.2

openshift-cherrypick-robot · 2021-03-17T17:43:42Z

@Miciah: new pull request created: #623

Details

In response to this:

/cherry-pick sdn-4.4-kubernetes-1.17.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service

a18cff1

This commit fixes bug 1919737. https://bugzilla.redhat.com/show_bug.cgi?id=1919737 * pkg/proxy/iptables/proxier.go (syncProxyRules): Prefer a local endpoint for the cluster DNS service.

openshift-ci-robot assigned Miciah Mar 4, 2021

openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 4, 2021

openshift-cherrypick-robot mentioned this pull request Mar 4, 2021

[sdn-4.6-kubernetes-1.18.6] Bug 1928773: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service #581

Merged

openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Mar 4, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 4, 2021

Miciah changed the title ~~[sdn-4.5-kubernetes-1.18.2] [sdn-4.6-kubernetes-1.18.6] Bug 1928773: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service~~ [sdn-4.5-kubernetes-1.18.2] Bug 1928773: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service Mar 4, 2021

Miciah changed the title ~~[sdn-4.5-kubernetes-1.18.2] Bug 1928773: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service~~ [sdn-4.5-kubernetes-1.18.2] Bug 1935297: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service Mar 4, 2021

Miciah mentioned this pull request Mar 4, 2021

Bug 1935297: Prefer local endpoint for cluster DNS service openshift/sdn#268

Merged

openshift-ci-robot assigned aojea Mar 5, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 9, 2021

openshift-ci-robot requested a review from lihongan March 9, 2021 01:01

deads2k removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 11, 2021

knobunc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2021

knobunc merged commit 0e43df9 into openshift:sdn-4.5-kubernetes-1.18.2 Mar 11, 2021

openshift-ci-robot mentioned this pull request Mar 12, 2021

Bug 1935297: Set CoreDNS readiness probe period and timeout each to 3 seconds openshift/cluster-dns-operator#242

Merged

openshift-cherrypick-robot mentioned this pull request Mar 17, 2021

[sdn-4.4-kubernetes-1.17.2] [sdn-4.5-kubernetes-1.18.2] Bug 1935297: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service #623

Closed

[sdn-4.5-kubernetes-1.18.2] Bug 1935297: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service #604

[sdn-4.5-kubernetes-1.18.2] Bug 1935297: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service #604

Uh oh!

Conversation

openshift-cherrypick-robot commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

Miciah commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

Miciah commented Mar 5, 2021

Uh oh!

aojea commented Mar 5, 2021

Uh oh!

openshift-bot commented Mar 6, 2021

Uh oh!

openshift-ci-robot commented Mar 6, 2021

Uh oh!

openshift-bot commented Mar 7, 2021

Uh oh!

openshift-ci-robot commented Mar 7, 2021

Uh oh!

openshift-bot commented Mar 8, 2021

Uh oh!

openshift-ci-robot commented Mar 8, 2021

Uh oh!

openshift-bot commented Mar 9, 2021

Uh oh!

openshift-ci-robot commented Mar 9, 2021

Uh oh!

knobunc commented Mar 11, 2021

Uh oh!

deads2k commented Mar 11, 2021

Uh oh!

deads2k commented Mar 11, 2021

Uh oh!

openshift-ci-robot commented Mar 11, 2021

Uh oh!

openshift-ci-robot commented Mar 11, 2021

Uh oh!

Miciah commented Mar 17, 2021

Uh oh!

openshift-cherrypick-robot commented Mar 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants