Bug 1935297: Prefer local endpoint for cluster DNS service #268

Miciah · 2021-03-04T15:38:29Z

Bump the vendored github.com/openshift/kubernetes to pick up openshift/kubernetes@a18cff1: "UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service".

go.mod: Bump github.com/openshift/kubernetes.
go.sum:
vendor/modules.txt: Regenerate.
vendor/k8s.io/kubernetes/pkg/proxy/iptables/proxier.go (syncProxyRules): Prefer a local endpoint for the cluster DNS service.

openshift-ci-robot · 2021-03-04T15:38:35Z

@Miciah: This pull request references Bugzilla bug 1935297, which is invalid:

expected dependent Bugzilla bug 1928773 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

WIP: Bug 1935297: Prefer local endpoint for cluster DNS service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2021-03-04T15:41:07Z

This PR is WIP because it vendors the openshift-cherrypick-robot branch to verify openshift/kubernetes#604. Once CI tests pass, we can merge openshift/kubernetes#604 and revendor this PR.

Miciah · 2021-03-04T20:22:54Z

/retest

Miciah · 2021-03-05T04:05:41Z

/test e2e-aws

knobunc · 2021-03-11T14:44:49Z

/approve

knobunc · 2021-03-11T14:44:58Z

/lgtm

knobunc · 2021-03-11T15:22:06Z

/bugzilla refresh

openshift-ci-robot · 2021-03-11T15:22:13Z

@knobunc: This pull request references Bugzilla bug 1935297, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1928773 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1928773 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bump the vendored github.com/openshift/kubernetes to pick up commit a18cff1620e79cfce7f212807f93bea87314511a: "UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service". This commit fixes bug 1935297. https://bugzilla.redhat.com/show_bug.cgi?id=1935297 * go.mod: Bump github.com/openshift/kubernetes. * go.sum: * vendor/modules.txt: Regenerate. * vendor/k8s.io/kubernetes/pkg/proxy/iptables/proxier.go (syncProxyRules): Prefer a local endpoint for the cluster DNS service.

knobunc · 2021-03-11T17:59:09Z

/lgtm

openshift-ci-robot · 2021-03-11T17:59:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knobunc · 2021-03-11T18:10:55Z

/bugzilla refresh

openshift-ci-robot · 2021-03-11T18:12:01Z

@knobunc: An error was encountered querying GitHub for users with public email ([email protected]) for bug 1935297 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n  \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-11T18:49:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

Miciah · 2021-03-11T19:36:34Z

/retest

Miciah · 2021-03-11T22:37:16Z

/retest

Miciah · 2021-03-12T06:53:53Z

/refresh

knobunc · 2021-03-12T13:46:45Z

/retest

knobunc · 2021-03-12T13:47:28Z

Test failed with quota error.

Miciah · 2021-03-12T15:54:10Z

/retest

knobunc · 2021-03-12T16:17:57Z

/retest

knobunc · 2021-03-12T17:34:36Z

/retest

openshift-bot · 2021-03-12T18:11:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

knobunc · 2021-03-12T19:39:01Z

/retest

openshift-ci-robot · 2021-03-12T21:27:33Z

@Miciah: All pull requests linked via external trackers have merged:

Bugzilla bug 1935297 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1935297: Prefer local endpoint for cluster DNS service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from alexanderConstantinescu and rcarrillocruz March 4, 2021 15:38

Miciah force-pushed the BZ1935297-prefer-local-endpoint-for-cluster-DNS-service branch from 6dff427 to 479cfce Compare March 4, 2021 16:05

Miciah mentioned this pull request Mar 5, 2021

[sdn-4.5-kubernetes-1.18.2] Bug 1935297: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service openshift/kubernetes#604

Merged

openshift-ci-robot assigned knobunc Mar 11, 2021

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 11, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 11, 2021

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 11, 2021

openshift-ci-robot requested a review from lihongan March 11, 2021 15:22

Miciah force-pushed the BZ1935297-prefer-local-endpoint-for-cluster-DNS-service branch from 479cfce to 22dde50 Compare March 11, 2021 17:51

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021

Miciah changed the title ~~WIP: Bug 1935297: Prefer local endpoint for cluster DNS service~~ Bug 1935297: Prefer local endpoint for cluster DNS service Mar 11, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021

knobunc added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Mar 11, 2021

crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 11, 2021

openshift-ci-robot mentioned this pull request Mar 12, 2021

Bug 1935297: Set CoreDNS readiness probe period and timeout each to 3 seconds openshift/cluster-dns-operator#242

Merged

openshift-merge-robot merged commit c9be458 into openshift:release-4.5 Mar 12, 2021

Bug 1935297: Prefer local endpoint for cluster DNS service #268

Bug 1935297: Prefer local endpoint for cluster DNS service #268

Uh oh!

Conversation

Miciah commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

Miciah commented Mar 4, 2021

Uh oh!

Miciah commented Mar 4, 2021

Uh oh!

Miciah commented Mar 5, 2021

Uh oh!

knobunc commented Mar 11, 2021

Uh oh!

knobunc commented Mar 11, 2021

Uh oh!

knobunc commented Mar 11, 2021

Uh oh!

openshift-ci-robot commented Mar 11, 2021

Uh oh!

knobunc commented Mar 11, 2021

Uh oh!

openshift-ci-robot commented Mar 11, 2021

Uh oh!

knobunc commented Mar 11, 2021

Uh oh!

openshift-ci-robot commented Mar 11, 2021

Uh oh!

openshift-bot commented Mar 11, 2021

Uh oh!

Miciah commented Mar 11, 2021

Uh oh!

Miciah commented Mar 11, 2021

Uh oh!

Miciah commented Mar 12, 2021

Uh oh!

knobunc commented Mar 12, 2021

Uh oh!

knobunc commented Mar 12, 2021

Uh oh!

Miciah commented Mar 12, 2021

Uh oh!

knobunc commented Mar 12, 2021

Uh oh!

knobunc commented Mar 12, 2021

Uh oh!

openshift-bot commented Mar 12, 2021

Uh oh!

knobunc commented Mar 12, 2021

Uh oh!

openshift-ci-robot commented Mar 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants