<carry>: enable CSI migration gates in Attach/Detach controller#601
Conversation
openshift-ci-robot
added
backports/unvalidated-commits
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
956890a to
56f25bb
Compare
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/retest |
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
56f25bb to
647ad25
Compare
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
647ad25 to
6768b20
Compare
jsafrane
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
|
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
6768b20 to
bf38af0
Compare
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
|
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
bf38af0 to
2d79793
Compare
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
|
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
Please provide more information to the carry commit, pointing to openshift/enhancements#549 and that this is owned by storage team and should be contacted with them around 3-4 releases, so around 4.11/4.12 for a potential drop.
The change lgtm, but I'd like architects to sign off the enhancement first before merging this.
openshift-ci-robot
added
the
approved
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
2d79793 to
637c19b
Compare
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
|
|
@soltysh better comment added + linked the enhancement in the commit message. |
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
637c19b to
1ccf882
Compare
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
|
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
1ccf882 to
0cda7a4
Compare
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
99dc6a7 to
ed8fae7
Compare
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
|
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
ed8fae7 to
a55fa8e
Compare
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
|
|
/retest |
1 similar comment
|
/retest |
jsafrane
changed the title
…t set of featuregates The volume plugin manager for openshfit's Attach Detach controller in kube-controller-manager uses a set of featuregates that are NOT the same as the the other controllers in KCM and the kubelet. This means these featuregates (if we kept the old names) would be inconsistent inside of a single binary. There are now separate featuregates for the volumepluginmanger when running in the Attach Detach controller to reflect this distintion. See openshift/enhancements#549 for details. Stop <carrying> the patch when CSI migration becomes GA (i.e. features.CSIMigrationAWS / features.CSIMigrationOpenStack are GA).
jsafrane
force-pushed
the
wip-fake-adc-features
branch
from
a55fa8e to
2d9a8f9
Compare
|
@jsafrane: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
Rebased to 1.21 |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws-serial |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
soltysh
removed
the
backports/unvalidated-commits
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-gcp |
|
@jsafrane: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
7 participants
Run A/D controller with CSI migration feature flags force-enabled.
There is very minimal
<carry>patch that forcefully sets CSI migration gates only in A/D controller. We will need it as<carry>patch until CSI migration of all volume plugins reaches GA (1.23-1.24?)See openshift/enhancements#549 for details.
The patch works around two issues we have in OCP:
CVO downgrades Kubernetes components in wrong order: kube-controller-manager (A/D controller) is downgraded first and then it downgrades kubelets. This is not supported Kubernetes version skew, kubelet cannot be newer than KCM. A/D controller breaks in this case.
FeatureGates are applied in random order. Without this PR, we need to enable CSI migration flag in A/D controller first, then kubelets. With this PR, the order does not matter.
With this PR, A/D controller knows about CSI migration and will attach volumes to nodes either "in-tree style" or "CSI style", depending what the node actually wants. In a default 4.8 cluster, it will be in-tree style, as CSI migration is disabled everywhere else, so there should be no visible change in A/D controller processing. It becomes useful as the CSI migration becomes enabled on nodes (either during upgrade to 4.9 or downgrade 4.9->4.8), or when user opts-in for CSI migration as tech preview in 4.8 via FeatureGates CR.