UPSTREAM: <carry>: add CSI migration feature gates for GCE PD and Azure Disk#831
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
| ADCCSIMigrationCinder featuregate.Feature = "ADC_CSIMigrationCinder" | ||
|
|
||
| // owner: @fbertina | ||
| // alpha: v1.22 |
There was a problem hiding this comment.
It says alpha here, but featuregate.Beta below. Can you please switch the doc of all gates to beta? It looks like an oversight.
|
The storage test failures are very suspicious, but it looks like one of the nodes had issues: /retest |
…re Disk This commit is the next natural step for commit 2d9a8f9. It introduces custom feature gates to enable the CSI migration in GCE PD and Azure Disk plugins. See openshift/enhancements#549 for details. Stop <carrying> the patch when CSI migration becomes GA (i.e. features.CSIMigrationAzureDisk / features.CSIMigrationGCE are GA).
bertinatto
force-pushed
the
gce-azure-csi
branch
from
035eff1 to
d37e84c
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/retest |
|
/lgtm |
|
I remember these feature gates. This PR makes it look like things are moving in a good direction. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, deads2k, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@deads2k who can remove |
soltysh
removed
the
backports/unvalidated-commits
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 participants
This is the continuation of #601.
It introduces custom feature gates to enable the CSI migration for GCE PD and Azure Disk in the AD controller.
See openshift/enhancements#549 for details.
CC @openshift/storage
Epics:
https://issues.redhat.com/browse/STOR-577
https://issues.redhat.com/browse/STOR-576