Skip to content

Fix network test exclusion#25581

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
danwinship:fix-network-test-exclusion
Oct 22, 2020
Merged

Fix network test exclusion#25581
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
danwinship:fix-network-test-exclusion

Conversation

@danwinship
Copy link
Contributor

@danwinship danwinship commented Oct 2, 2020 •
edited
Loading

Completes openshift/kubernetes#382 by revendoring and making the corresponding origin-side changes (resulting in a bunch of tests being un-skipped under ovn-kubernetes, and eventually in third-party network plugins).

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2020

@danwinship: GitHub didn't allow me to request PR reviews from the following users: danwinship.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

testing openshift/kubernetes#382
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. vendor-update Touching vendor dir or related files labels Oct 2, 2020
@danwinship
Copy link
Contributor Author

danwinship commented Oct 5, 2020

/test e2e-gcp-ovn

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2020

@danwinship: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-cmd
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-openstack
  • /test e2e-vsphere
  • /test images
  • /test verify
  • /test verify-deps
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking

Use /test all to run the following jobs:

  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-fips
  • pull-ci-openshift-origin-master-e2e-aws-serial
  • pull-ci-openshift-origin-master-e2e-cmd
  • pull-ci-openshift-origin-master-e2e-gcp
  • pull-ci-openshift-origin-master-e2e-gcp-builds
  • pull-ci-openshift-origin-master-e2e-gcp-upgrade
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps
Details

In response to this:

/test e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor Author

danwinship commented Oct 5, 2020

/test e2e-aws-ovn

@danwinship
Copy link
Contributor Author

danwinship commented Oct 6, 2020

/test all

@danwinship
Copy link
Contributor Author

danwinship commented Oct 6, 2020

/test e2e-aws-ovn

3 similar comments
@danwinship
Copy link
Contributor Author

danwinship commented Oct 7, 2020

/test e2e-aws-ovn

@danwinship
Copy link
Contributor Author

danwinship commented Oct 8, 2020

/test e2e-aws-ovn

@danwinship
Copy link
Contributor Author

danwinship commented Oct 9, 2020

/test e2e-aws-ovn

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2020
@danwinship
Copy link
Contributor Author

danwinship commented Oct 9, 2020

/test e2e-aws-ovn

@danwinship danwinship force-pushed the fix-network-test-exclusion branch from 803241e to b0930eb Compare October 9, 2020 17:24
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2020
@danwinship
Copy link
Contributor Author

danwinship commented Oct 9, 2020

/test e2e-aws-ovn

@danwinship danwinship force-pushed the fix-network-test-exclusion branch from b0930eb to 4b2bb04 Compare October 9, 2020 21:03
@danwinship
Copy link
Contributor Author

danwinship commented Oct 9, 2020

/test e2e-aws-ovn

@danwinship
Copy link
Contributor Author

danwinship commented Oct 9, 2020

/cc @marun

@marun
Copy link
Contributor

marun commented Oct 9, 2020

@danwinship lgtm, and I appreciate your taking the time to fix the docs!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2020

@danwinship: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-deps 4b2bb04 link /test verify-deps
ci/prow/e2e-cmd 4b2bb04 link /test e2e-cmd
ci/prow/e2e-aws-ovn 4b2bb04 link /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship
Copy link
Contributor Author

danwinship commented Oct 14, 2020

/test e2e-aws-ovn

@danwinship danwinship force-pushed the fix-network-test-exclusion branch from 4b2bb04 to 67187e7 Compare October 16, 2020 18:08
@danwinship danwinship changed the title WIP Fix network test exclusion Fix network test exclusion Oct 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2020
@danwinship
bump(k8s.io/kubernetes)
b40adab
@danwinship
Fix up and regenerate test annotations
65fd0f8 
Add a rule here to balance out a rule removed from
openshift/kubernetes, and regenerate.

This un-skips a bunch of tests under ovn-kubernetes that were
previously skipped unconditionally.
@danwinship
Clarify the split between o/k and o/o e2e test annotations.
099a02f
@danwinship
Belatedly un-skip two passing tests
38e841d 
Un-disable a multitenant test that we unexpectedly fixed, and an
ovn-kubernetes test that had been skipped because of an upstream flake
which has since been fixed.
@danwinship danwinship force-pushed the fix-network-test-exclusion branch from 67187e7 to 38e841d Compare October 16, 2020 22:12
@danwinship
Copy link
Contributor Author

danwinship commented Oct 17, 2020

/auto-cc
/assign @knobunc

@marun
Copy link
Contributor

marun commented Oct 21, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@knobunc
Copy link
Contributor

knobunc commented Oct 22, 2020

/approve

Thanks Dan

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, knobunc, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit fc22751 into openshift:master Oct 22, 2020
@danwinship danwinship deleted the fix-network-test-exclusion branch January 6, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marun marun Awaiting requested review from marun

@bparees bparees Awaiting requested review from bparees

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@marun marun

@knobunc knobunc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danwinship @openshift-ci-robot @marun @knobunc @openshift-merge-robot