OCPBUGS-61754: UPSTREAM: <carry>: Add retries for GetCurrentResourceVersion. #2467
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@benluddy: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
Corresponding patch for the k8s.io/apiserver fork that the aggregated apiservers use: openshift/kubernetes-apiserver#72. |
openshift-ci
bot
added
vendor-update
| // are purely passthroughs to the delegate. During a rebase, consider whether or not it is | ||
| // safe and appropriate for a new method added to the method set of storage.Interface to | ||
| // perform retries. | ||
| delegate storage.Interface |
There was a problem hiding this comment.
this is the same code as in openshift/kubernetes-apiserver#72
benluddy
force-pushed
the
etcd-retry-getcurrentresourceversion
branch
from
a79faa7 to
bd238e1
Compare
|
@benluddy: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/lgtm |
benluddy
changed the title
|
/remove-label backports/unvalidated-commits |
openshift-ci
bot
removed
the
backports/unvalidated-commits
benluddy
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@benluddy: This pull request references Jira Issue OCPBUGS-61754, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified later @benluddy |
openshift-ci-robot
added
verified-later
verified
|
@benluddy: This PR has been marked to be verified later by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.20 |
|
@benluddy: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@benluddy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 95b8140
into
openshift:master
|
@benluddy: Jira Issue OCPBUGS-61754: All pull requests linked via external trackers have merged: This pull request has the In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@benluddy: new pull request created: #2469 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-09-18-193221 |
5 participants
No description provided.