Skip to content

Conversation

@benluddy
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link

coderabbitai bot commented Sep 16, 2025

Walkthrough

Updated a single replace directive in go.mod to point k8s.io/apiserver to a newer pseudo-version of openshift/kubernetes-apiserver. No other files or declarations changed.

Changes

Cohort / File(s) Summary of Changes
Go module replace update
go.mod
Updated replace for k8s.io/apiserver to github.com/openshift/kubernetes-apiserver at v0.0.0-20250917144435-182485d204aa from v0.0.0-20250903191822-f755b07b63ce; no other entries modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description Check ❓ Inconclusive The pull request has no author-provided description (pr_description is empty), so there is insufficient information to determine whether the description is related to the changeset; the title and raw_summary indicate a dependency bump but the missing description prevents a lenient pass. Because the description field is empty rather than documenting intent, scope, or testing, the check is inconclusive. Confirming relation or adequacy requires the author to provide descriptive text. Please add a short description that summarizes what was bumped and why, reference OCPBUGS-61754, note any testing or impact, and state whether the PR is ready for merge or still WIP so the description check can be completed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "OCPBUGS-61754: Bump openshift/kubernetes-apiserver for consistent list etcd retries." directly reflects the primary change in the raw_summary, which updates the go.mod replace entry to a newer openshift/kubernetes-apiserver pseudo-version. It includes the Jira ID and a concise rationale for the bump, making the intent clear to reviewers. The title is specific, focused, and suitable for history scanning.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between a187f61 and d6cece1.

⛔ Files ignored due to path filters (3)
  • go.sum is excluded by !**/*.sum
  • vendor/k8s.io/apiserver/pkg/storage/etcd3/etcd3retry/retry_etcdclient.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (1)
  • go.mod (1 hunks)
🔇 Additional comments (1)
go.mod (1)

201-201: Bump looks fine — vendor and verify etcd-retry commit (verification inconclusive)

  • My verification script produced no output, so I couldn't confirm the go.mod replace or inspect commit 182485d204aa. From the repo root, run and paste results of:
    • rg -nP '^k8s.io/apiserver\s*=>\s*github.com/openshift/kubernetes-apiserver\s+v' go.mod
    • git ls-remote https://github.com/openshift/kubernetes-apiserver.git 182485d204aa
    • gh api repos/openshift/kubernetes-apiserver/commits/182485d204aa -q '.sha, .commit.author.date, .commit.message' (requires gh auth)
    • rg -n 'github.com/openshift/kubernetes-apiserver' vendor/modules.txt || echo 'vendor/modules.txt not found'
  • Ensure vendor/modules.txt is updated to the new pseudo‑version and that 182485d includes the "consistent list etcd retries" change. No other k8s replaces changed; skew with v0.33.3 components looks OK.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2025
@benluddy
Copy link
Contributor Author

/payload-aggregate ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

@benluddy: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@benluddy
Copy link
Contributor Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96a681d0-9340-11f0-8024-13a82f086c2b-0

@benluddy benluddy force-pushed the apiserver-bump-etcd-retrier-getcurrentresourceversion branch from 914cfa4 to d6cece1 Compare September 17, 2025 14:45
@p0lyn0mial
Copy link
Contributor

/lgtm

@benluddy benluddy changed the title Bump openshift/kubernetes-apiserver for consistent list etcd retries. OCPBUGS-61754: Bump openshift/kubernetes-apiserver for consistent list etcd retries. Sep 17, 2025
@benluddy benluddy marked this pull request as ready for review September 17, 2025 14:52
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 17, 2025
@openshift-ci-robot
Copy link

@benluddy: This pull request references Jira Issue OCPBUGS-61754, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@p0lyn0mial p0lyn0mial added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2025
@openshift-ci openshift-ci bot requested a review from geliu2016 September 17, 2025 14:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [benluddy,p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benluddy
Copy link
Contributor Author

/verified later @benluddy

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Sep 17, 2025
@openshift-ci-robot
Copy link

@benluddy: This PR has been marked to be verified later by @benluddy.

Details

In response to this:

/verified later @benluddy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2025

@benluddy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 42b97a8 into openshift:main Sep 17, 2025
14 checks passed
@openshift-ci-robot
Copy link

@benluddy: Jira Issue OCPBUGS-61754: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-61754 has not been moved to the MODIFIED state.

This PR is marked as verified-later. Jira issue(s) in the title of this PR will require post-merge verification. After testing, it must be manually moved to the VERIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.21.0-0.nightly-2025-09-18-193221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants