OCPBUGS-61754: UPSTREAM: <carry> Add retries for GetCurrentResourceVersion. #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0lyn0mial
reviewed
Sep 17, 2025
| // are purely passthroughs to the delegate. During a rebase, consider whether or not it is | ||
| // safe and appropriate for a new method added to the method set of storage.Interface to | ||
| // perform retries. | ||
| delegate storage.Interface |
p0lyn0mial
reviewed
Sep 17, 2025
| err error | ||
| ) | ||
| return rv, OnError(ctx, DefaultRetry, IsRetriableErrorOnRead, func() error { | ||
| rv, err = c.delegate.GetCurrentResourceVersion(ctx) |
p0lyn0mial
reviewed
Sep 17, 2025
| err error | ||
| ) | ||
| return rv, OnError(ctx, DefaultRetry, IsRetriableErrorOnRead, func() error { | ||
| rv, err = c.delegate.GetCurrentResourceVersion(ctx) |
|
/lgtm |
p0lyn0mial
merged commit 182485d
into
openshift:openshift-apiserver-4.20-kubernetes-1.33
benluddy
changed the title
|
@benluddy: Jira Issue OCPBUGS-61754: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-61754 has not been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.