Skip to content

Conversation

@ricky-rav
Copy link

… of the topology label.

(cherry picked from commit 82852c0)

This is part of the solution for BZ 2040715.

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2022

@ricky-rav: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

BZ 2040715: upstream fix: fix: do not return early in the node informer when there is no change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 16, 2022
@openshift-ci-robot
Copy link

@ricky-rav: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ricky-rav ricky-rav changed the title BZ 2040715: upstream fix: fix: do not return early in the node informer when there is no change Bug 2040715: upstream fix: fix: do not return early in the node informer when there is no change Feb 16, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2022

@ricky-rav: This pull request references Bugzilla bug 2040715, which is invalid:

  • expected Bugzilla bug 2040715 to depend on a bug targeting a release in 4.11.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2040715: upstream fix: fix: do not return early in the node informer when there is no change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from soltysh and sttts February 16, 2022 16:59
@ricky-rav ricky-rav force-pushed the dev_az_node_informer_upstream_fix branch from 833f442 to c507bd1 Compare February 16, 2022 16:59
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Feb 16, 2022
@openshift-ci-robot
Copy link

@ricky-rav: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ricky-rav ricky-rav changed the title Bug 2040715: upstream fix: fix: do not return early in the node informer when there is no change Bug 2040715: UPSTREAM 108149: fix: do not return early in the node informer when there is no change Feb 16, 2022
@deads2k
Copy link

deads2k commented Feb 18, 2022

Please update the commit message for kubernetes#108177

UPSTREAM: 108177: fix: do not return early in the node informer when there is no change

/approve

@deads2k deads2k added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). labels Feb 18, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
@openshift-ci-robot
Copy link

@ricky-rav: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

…there is no change of the topology label.

(cherry picked from commit 82852c0)
Signed-off-by: Riccardo Ravaioli <[email protected]>
@ricky-rav ricky-rav force-pushed the dev_az_node_informer_upstream_fix branch from fabb596 to 00499ab Compare February 24, 2022 12:27
@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Feb 24, 2022
@openshift-ci-robot
Copy link

@ricky-rav: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot openshift-ci-robot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 24, 2022
@deads2k deads2k added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 24, 2022
@deads2k
Copy link

deads2k commented Feb 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ricky-rav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link

deads2k commented Feb 24, 2022

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2022

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-gcp

In response to this:

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kubernetes/1183/pull-ci-openshift-kubernetes-release-4.10-e2e-gcp/1496824274055335936 looks good

/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6870fb7 into openshift:release-4.10 Feb 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2022

@ricky-rav: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2040715 has not been moved to the MODIFIED state.

In response to this:

Bug 2040715: UPSTREAM 108149: fix: do not return early in the node informer when there is no change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2022

@ricky-rav: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-cgroupsv2 00499ab link false /test e2e-aws-cgroupsv2
ci/prow/e2e-openstack-csi-manila 00499ab link false /test e2e-openstack-csi-manila

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants