Bug 2040715: UPSTREAM: 108284: fix: exclude non-ready nodes from azure load balancer #1190
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
ricky-rav
force-pushed
the
dev_2040715_nodestatus
branch
from
59c9d0e to
fdcd1d1
Compare
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload 4.10 ci blocking |
|
@deads2k: trigger 5 jobs of type blocking for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c92d2360-9417-11ec-9359-5b4998044e47-0 trigger 7 jobs of type blocking for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c92d2360-9417-11ec-9359-5b4998044e47-1 |
|
/payload 4.10 nightly blocking |
|
@deads2k: trigger 7 jobs of type blocking for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e595cc0-9420-11ec-9fbc-8a55d5a5e767-0 |
|
/payload 4.11 nightly blocking |
|
@petr-muller: trigger 7 jobs of type blocking for the nightly release of OCP 4.11
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/449b7fa0-9487-11ec-8458-215aaa01b68f-0 |
|
This is a master PR and master is 4.11 |
ricky-rav
force-pushed
the
dev_2040715_nodestatus
branch
from
fdcd1d1 to
4b0b589
Compare
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
ricky-rav
force-pushed
the
dev_2040715_nodestatus
branch
from
4b0b589 to
a0223b5
Compare
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
ricky-rav
changed the title
openshift-ci
bot
added
bugzilla/severity-urgent
|
@ricky-rav: This pull request references Bugzilla bug 2040715, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm discussed with @tkashem and we'll allow these to merge first. |
deads2k
removed
the
backports/unvalidated-commits
deads2k
added
the
approved
ricky-rav
force-pushed
the
dev_2040715_nodestatus
branch
from
47506ad to
fed1a03
Compare
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@ricky-rav: This pull request references Bugzilla bug 2040715, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
deads2k
removed
the
backports/unvalidated-commits
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
ricky-rav
force-pushed
the
dev_2040715_nodestatus
branch
from
fed1a03 to
82abbb6
Compare
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
… azure load balancers Exclude from Azure load balancers nodes that are not in the ready state and nodes that are being deleted from the cluster. Signed-off-by: Riccardo Ravaioli <[email protected]> (cherry picked from commit 5b9150b247d129b5444ca7a432a71a712a00dfc1)
ricky-rav
force-pushed
the
dev_2040715_nodestatus
branch
from
82abbb6 to
a59fd94
Compare
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/lgtm |
deads2k
removed
the
backports/unvalidated-commits
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, ricky-rav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@ricky-rav: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@ricky-rav: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2040715 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
This patch makes sure that non-ready nodes and deleted nodes are removed from azure load balancers.
Fixes #2040715
Signed-off-by: Riccardo Ravaioli [email protected]