Bug 2056948: UPSTREAM: 108284: fix: exclude non-ready nodes from azure load balancer #1195
Conversation
|
@ricky-rav: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
ricky-rav
force-pushed
the
fix_108283_410
branch
from
c3b4566 to
9644708
Compare
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
let's get this updated with code matchhing the upstream PR and a commit title in the format
|
ricky-rav
force-pushed
the
fix_108283_410
branch
from
9644708 to
ded57ce
Compare
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
ricky-rav
force-pushed
the
fix_108283_410
branch
from
ded57ce to
4272238
Compare
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
ricky-rav
changed the title
|
@ricky-rav: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ricky-rav
changed the title
openshift-ci
bot
added
bugzilla/severity-urgent
|
@ricky-rav: This pull request references Bugzilla bug 2056948, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
|
@ricky-rav: This pull request references Bugzilla bug 2056948, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ricky-rav: This pull request references Bugzilla bug 2056948, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm discussed with @tkashem and we'll allow these to merge first. |
deads2k
added
staff-eng-approved
openshift-ci
bot
added
lgtm
|
/lgtm cancel comment on the upstream. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
ricky-rav
force-pushed
the
fix_108283_410
branch
from
0b76484 to
8620822
Compare
openshift-ci-robot
added
the
backports/unvalidated-commits
openshift-ci
bot
added
needs-rebase
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
… azure load balancers Exclude from Azure load balancers nodes that are not in the ready state and nodes that are being deleted from the cluster. Signed-off-by: Riccardo Ravaioli <[email protected]> (cherry picked from commit 5b9150b247d129b5444ca7a432a71a712a00dfc1)
ricky-rav
force-pushed
the
fix_108283_410
branch
from
8620822 to
a1b5ec9
Compare
openshift-ci
bot
removed
the
needs-rebase
|
@ricky-rav: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
deads2k
removed
the
backports/unvalidated-commits
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, ricky-rav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@ricky-rav: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@ricky-rav: All pull requests linked via external trackers have merged: Bugzilla bug 2056948 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
This patch makes sure that non-ready nodes and deleted nodes are removed from azure load balancers.
Fixes #2056948
Signed-off-by: Riccardo Ravaioli [email protected]