*: add support for platform none #982
Merged
+73
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
crawford
changed the title
openshift-ci-robot
added
size/L
wking
reviewed
Jan 3, 2019
Contributor
|
This produces correct config here, needs MCO to support that platform to have it working e2e |
1 task
openshift-ci-robot
added
size/M
Member
|
/lgtm |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
Author
|
@wking I rebased onto master. There shouldn't be any code changes. |
Contributor
Author
Member
|
/lgtm The |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
Author
|
Last failure: |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
Author
|
Last failure: |
Contributor
Author
|
Last failure: That's three identical failures in a row... I could have sworn this code passed before. |
Contributor
Author
|
I'm going to babysit this one and try to figure out what's going on... /retest |
Contributor
Author
Boo. |
This adds support for the "none" platform. This is used in situations where the infrastructure will not be managed (bring-your-own). Additionally, since the infrastructure is unmanaged, the installer cannot create the infrastructure and the "cluster" target is therefore invalid when used with the "none" platform. For this reason, the "none" platform is hidden in the UX. It is still possible to use, but the install-config will need an empty "none" object under platform.
Member
|
The only thing that changed from f5d48a5 -> f350f2c was the commit date? Still /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
Clayton says he fixed something. /retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest |
Member
|
/test e2e-aws |
Contributor
|
/retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest |
Contributor
Author
|
@vrutkovs do you know what has caused the recent failures? |
Contributor
Author
|
The last one looks like a series of storage failures again. |
Contributor
|
Seems openshift/origin#21727 should fix (some) storage issues |
Contributor
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the "none" platform. This is used in situations
where the infrastructure will not be managed (bring-your-own).
Additionally, since the infrastructure is unmanaged, the installer
cannot create the infrastructure and the "cluster" target is therefore
invalid when used with the "none" platform. For this reason, the "none"
platform is hidden in the UX. It is still possible to use, but the
install-config will need an empty "none" object under platform.
cc @vrutkovs @wking @abhinavdahiya