Skip to content

Fix hostpath conformance e2e #21727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smarterclayton merged 2 commits into from
Jan 4, 2019
Merged

Fix hostpath conformance e2e #21727

smarterclayton merged 2 commits into from
Jan 4, 2019

Conversation

@gnufied
Copy link
Member

@gnufied gnufied commented Jan 3, 2019

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 3, 2019
@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 3, 2019

/test e2e-aws-all

@gnufied gnufied mentioned this pull request Jan 3, 2019
Closed
@gnufied
Copy link
Member Author

gnufied commented Jan 3, 2019

We need to backport second commit in this PR to 1.12 rebase branch. I will make sure this happens.

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 3, 2019

Thanks

@wking wking mentioned this pull request Jan 3, 2019
Merged
@gnufied
Copy link
Member Author

gnufied commented Jan 4, 2019

The failure in test-unit appears to be unrelated flake.

@gnufied
Copy link
Member Author

gnufied commented Jan 4, 2019

/test unit

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 4, 2019

/test e2e-aws-all

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 4, 2019

/test e2e-aws

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 4, 2019

/test e2e-aws
/test e2e-aws-all

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 4, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton smarterclayton merged commit bbfbb69 into openshift:master Jan 4, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 4, 2019

@gnufied: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-all 86c76ab link /test e2e-aws-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon Awaiting requested review from copejon

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gnufied @smarterclayton @openshift-ci-robot @openshift-bot