Support "none" cloudprovider

[vrutkovs]

After openshift/installer#982 was merged BYOR installs use platform: none. Our install waits for all CVO operators to complete successfully, but kube-controller-manager-operator fails with this setup:

      - apiVersion: config.openshift.io/v1
        kind: ClusterOperator
        metadata:
          creationTimestamp: '2019-01-08T16:39:29Z'
          generation: 1
          name: openshift-kube-controller-manager-operator
          namespace: ''
          resourceVersion: '10227'
          selfLink: /apis/config.openshift.io/v1/clusteroperators/openshift-kube-controller-manager-operator
          uid: f80027da-1363-11e9-85a4-42010af00002
        spec: {}
        status:
          conditions:
          - lastTransitionTime: '2019-01-08T16:49:28Z'
            message: 'ConfigObservationFailing: configmap/cluster-config-v1.kube-system: no recognized cloud provider platform found: map[string]interface {}{"none":map[string]interface {}{}}'
            reason: ConfigObservationFailing
            status: 'True'
            type: Failing
          - lastTransitionTime: '2019-01-08T16:49:28Z'
            message: 3 of 3 nodes are at revision 1
            status: 'True'
            type: Available
          - lastTransitionTime: '2019-01-08T16:49:28Z'
            message: 3 of 3 nodes are at revision 1
            reason: AllNodesAtLatestRevision
            status: 'False'
            type: Progressing
          extension: null
          version: ''

This PR adds a support for this platform (as libvirt it doesn't modify extendedArguments) and updates tests to verify these three cases.

Don't know how to test that config was not modified, but I could extend the tests later on. Implemented

Verified that it unblocks platform: none installs

Fixes #100

[vrutkovs]

/retest

[vrutkovs]

/retest

[frobware]

LGTM, but wondering why the "libvirt" and "none" testcases are different than aws for the expected cloudprovider field.

[frobware]

Given the "aws" test case, how come this is not "libvirt"? Perhaps I didn't look closely enough but I see for libvirt we return return observerConfig, errs - curious as to why "aws" is more explicit.

[vrutkovs]

This var is not being checked, as the func would immediately return observedConfig so in test ObserveCloudProviderNames would return immediately.

Reworked the test:

• cloudProvider is not initialized for none and libvirt
• test struct has cloudProviderNum - expected number of cloudproviders
• test now ensures expected and actual number of cloudproviders are equals

[frobware]

I think cloudProviderNum is better expressed as cloudProviderCount. For me (at least) Num looks like an index.

[vrutkovs]

Right, I was choosing between these two, renamed to Count

[frobware]

/lgtm

[frobware]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/operator/configobservation/cloudprovider/OWNERS [frobware]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrutkovs]

/retest

[vrutkovs]

/test e2e-aws

[ingvagabund]

Does the none need to be specifies explicitly? Just asking what is the difference when the cloud provider is not specified and when it is set to none.

[vrutkovs]

none is the platform name in the installer, not cloudprovider name