Skip to content

CORS-3417: capa bump fallout #8169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Mar 15, 2024
Merged

CORS-3417: capa bump fallout #8169

openshift-merge-bot merged 2 commits into from
Mar 15, 2024

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Mar 15, 2024

Fallout from #8114. I missed the replace pinning the CAPA version to 2.4.0.

We need the newer version to be able to specify ignition proxy information.

r4f4 added 2 commits March 15, 2024 15:41
@r4f4
capi/aws: bump capa version
c190c68 
Fallout from openshift#8114. I missed
the replacing pinning the CAPA version to 2.4.0.

We need the newer version to be able to specify ignition proxy
information.
@r4f4
capi/aws: update vendor
0c0b444
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 15, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 15, 2024

@r4f4: This pull request explicitly references no jira issue.

Details

In response to this:

Fallout from #8114. I missed the replace pinning the CAPA version to 2.4.0.

We need the newer version to be able to specify ignition proxy information.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 15, 2024 •
edited by openshift-ci bot
Loading

/retitle CORS-3417: capa bump fallout

@openshift-ci openshift-ci bot changed the title no-jira: capa bump fallout CORS-3417: capa bump fallout Mar 15, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 15, 2024 •
edited by openshift-ci bot
Loading

@r4f4: This pull request references CORS-3417 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Fallout from #8114. I missed the replace pinning the CAPA version to 2.4.0.

We need the newer version to be able to specify ignition proxy information.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from patrickdillon and rwsu March 15, 2024 14:48
@r4f4
Copy link
Contributor Author

r4f4 commented Mar 15, 2024

/uncc @rwsu
/cc @mtulio

@openshift-ci openshift-ci bot requested review from mtulio and removed request for rwsu March 15, 2024 15:01
@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 15, 2024

/approve
/lgtm

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 15, 2024

/label acknowledge-critical-fixes-only
CAPI changes are behind a feature gate.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 15, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
mtulio
mtulio reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@mtulio mtulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@r4f4 r4f4 mentioned this pull request Mar 15, 2024
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-aws-ovn-wavelengthzones 0c0b444 link false /test altinfra-e2e-aws-ovn-wavelengthzones
ci/prow/okd-e2e-aws-ovn-upgrade 0c0b444 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5a1f5c2 into openshift:master Mar 15, 2024
@r4f4 r4f4 deleted the capa-bump-fallout branch March 15, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

1 more reviewer

@mtulio mtulio mtulio left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mtulio mtulio

@patrickdillon patrickdillon

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@r4f4 @openshift-ci-robot @patrickdillon @mtulio