Skip to content

Comments

OPNET-357: Populate network configuration at install-time#7604

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
mkowalski:OPNET-357
Feb 2, 2024
Merged

OPNET-357: Populate network configuration at install-time#7604
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
mkowalski:OPNET-357

Conversation

@mkowalski
Copy link
Contributor

@mkowalski mkowalski commented Oct 18, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 18, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 18, 2023 •
edited by openshift-ci bot
Loading

@mkowalski: This pull request references OPNET-357 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mkowalski
Copy link
Contributor Author

mkowalski commented Oct 18, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

@mkowalski: The following commands are available to trigger required jobs:

  • /test agent-integration-tests
  • /test altinfra-images
  • /test aro-unit
  • /test e2e-agent-compact-ipv4
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-scos-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test altinfra-e2e-aws-ovn
  • /test altinfra-e2e-aws-ovn-imdsv2
  • /test altinfra-e2e-aws-ovn-localzones
  • /test altinfra-e2e-aws-ovn-shared-vpc
  • /test altinfra-e2e-aws-ovn-shared-vpc-localzones
  • /test altinfra-e2e-azure-ovn
  • /test altinfra-e2e-azure-ovn-resourcegroup
  • /test altinfra-e2e-azure-ovn-shared-vpc
  • /test e2e-agent-compact-ipv4-appliance
  • /test e2e-agent-compact-ipv4-none-platform
  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv4-pxe
  • /test e2e-agent-sno-ipv6
  • /test e2e-alibaba
  • /test e2e-aws-custom-security-groups
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-localzones
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-public-subnets
  • /test e2e-aws-ovn-shared-vpc
  • /test e2e-aws-ovn-shared-vpc-localzones
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-upi-proxy
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-ovn-shared-vpc
  • /test e2e-gcp-ovn-xpn
  • /test e2e-gcp-secureboot
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-libvirt
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-sdn-swapped-hosts
  • /test e2e-metal-ipi-sdn-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix-ovn
  • /test e2e-nutanix-sdn
  • /test e2e-openstack-ccpmso
  • /test e2e-openstack-ccpmso-zone
  • /test e2e-openstack-dualstack-techpreview
  • /test e2e-openstack-externallb
  • /test e2e-openstack-nfv-intel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-sdn-parallel
  • /test e2e-openstack-upi
  • /test e2e-vsphere-static-ovn
  • /test e2e-vsphere-upi-zones
  • /test e2e-vsphere-zones
  • /test okd-e2e-agent-compact-ipv4
  • /test okd-e2e-agent-sno-ipv6
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-ovn-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test okd-scos-e2e-agent-compact-ipv4
  • /test okd-scos-e2e-agent-sno-ipv6
  • /test okd-scos-e2e-aws-ovn
  • /test okd-scos-e2e-aws-upgrade
  • /test okd-scos-e2e-gcp
  • /test okd-scos-e2e-gcp-ovn-upgrade
  • /test okd-scos-e2e-vsphere
  • /test okd-scos-unit
  • /test okd-scos-verify-codegen
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-altinfra-images
  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-aws-custom-security-groups
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-vsphere-ovn
  • pull-ci-openshift-installer-master-e2e-vsphere-zones
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-scos-images
  • pull-ci-openshift-installer-master-okd-scos-unit
  • pull-ci-openshift-installer-master-okd-scos-verify-codegen
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski
Copy link
Contributor Author

mkowalski commented Oct 18, 2023

/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack-ovn
/test e2e-vsphere-ovn

@mkowalski
Copy link
Contributor Author

mkowalski commented Oct 18, 2023

Metal and vSphere succeded. OpenStack failed because of my copy-paste error that I have already fixed. Now we are only waiting for openshift/api#1593 to merge so that the custom vendor hack is not needed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2023
@mkowalski
Copy link
Contributor Author

mkowalski commented Nov 24, 2023

/test e2e-metal-ipi-ovn-dualstack
/test e2e-aws-ovn
/test e2e-gcp-ovn

@mkowalski mkowalski force-pushed the OPNET-357 branch 2 times, most recently from 94a5c15 to 3ea10a6 Compare November 24, 2023 18:11
@mkowalski
Copy link
Contributor Author

mkowalski commented Nov 24, 2023

/test e2e-metal-ipi-ovn-dualstack
/test e2e-aws-ovn
/test e2e-gcp-ovn

@mkowalski
Copy link
Contributor Author

mkowalski commented Nov 27, 2023

/test e2e-metal-ipi-ovn-dualstack
/test e2e-aws-ovn
/test e2e-gcp-ovn

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@mkowalski mkowalski force-pushed the OPNET-357 branch 4 times, most recently from ba7518b to fb9c14e Compare November 28, 2023 12:49
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@mkowalski mkowalski marked this pull request as ready for review November 28, 2023 12:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@openshift-ci openshift-ci bot requested review from jcpowermac and rna-afk November 28, 2023 12:52
@mkowalski
Copy link
Contributor Author

mkowalski commented Nov 28, 2023

It may (or may not) need #7748. API has been already bumped but without client-go I expect some failures still to happen

@mkowalski
Copy link
Contributor Author

mkowalski commented Nov 28, 2023

/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack-ovn
/test e2e-vsphere-ovn

@mkowalski
Copy link
Contributor Author

mkowalski commented Nov 28, 2023

/retest-required

@mkowalski
Copy link
Contributor Author

mkowalski commented Nov 28, 2023

/cc @cybertron
Ready to review, OpenStack installed successfully (failed on unrelated conformance) and Metal passed completely

@openshift-ci openshift-ci bot requested a review from cybertron November 28, 2023 22:30
@cybertron
Copy link
Member

cybertron commented Nov 30, 2023

/lgtm

/test e2e-vsphere-ovn
/test e2e-metal-ipi
/test e2e-openstack-ovn

I think this was only rebased since the metal and OpenStack jobs passed, but we should make sure to get a VSphere pass on this too since we're touching that code.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@jcpowermac
Copy link
Contributor

jcpowermac commented Nov 30, 2023

There is issue with the csi driver w/zonal.

/lgtm

@rvanderp3 @vr4manta for awareness

@mkowalski
Copy link
Contributor Author

mkowalski commented Dec 4, 2023 •
edited
Loading

/hold

We get this in only after branching (feature targeted now for 4.16).

Once openshift/api#1695 merges, this is ready

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023 •
edited
Loading

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/terraform-images 5c002454f66472621286e90afbacff19e3320f41 link true /test terraform-images
ci/prow/terraform-verify-vendor 5c002454f66472621286e90afbacff19e3320f41 link true /test terraform-verify-vendor
ci/prow/e2e-gcp-ovn c5e21460f99c64073f3f59e201922e1bbb2f60dd link true /test e2e-gcp-ovn
ci/prow/e2e-vsphere-zones b42660b link false /test e2e-vsphere-zones
ci/prow/e2e-vsphere-zones-techpreview b42660b link false /test e2e-vsphere-zones-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mkowalski
Copy link
Contributor Author

mkowalski commented Jan 4, 2024

Waiting for #7869. Once that merges, code in this PR will compile

@mkowalski mkowalski mentioned this pull request Jan 11, 2024
Merged
@mkowalski
Copy link
Contributor Author

mkowalski commented Jan 11, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2024
@mkowalski
Copy link
Contributor Author

mkowalski commented Jan 11, 2024

/test e2e-vsphere-ovn
/test e2e-metal-ipi

@mkowalski
Copy link
Contributor Author

mkowalski commented Jan 11, 2024

/test e2e-metal-ipi-ovn-ipv6

@mkowalski
Copy link
Contributor Author

mkowalski commented Jan 12, 2024

/cc @cybertron

Ready to review. Metal, vSphere and OpenStack job passed

@mkowalski
Copy link
Contributor Author

mkowalski commented Jan 12, 2024

/cc @jcpowermac
As previous reviewer (#7604 (comment)), this has been rebased

@mkowalski
Copy link
Contributor Author

mkowalski commented Jan 12, 2024

Hey @sadasu, any chance you look at this here as you approved the recent API bump?

@sadasu
Copy link
Contributor

sadasu commented Feb 2, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@sadasu
Copy link
Contributor

sadasu commented Feb 2, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 59e3323 into openshift:master Feb 2, 2024
@mkowalski mkowalski deleted the OPNET-357 branch February 3, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@rna-afk rna-afk Awaiting requested review from rna-afk

@cybertron cybertron Awaiting requested review from cybertron

Assignees

@cybertron cybertron

@jcpowermac jcpowermac

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mkowalski @openshift-ci-robot @cybertron @jcpowermac @sadasu @openshift-merge-robot