Skip to content

Comments

SPLAT-1272: Modify the terraform variables to support Nutanix Failure Domains#7806

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
nutanix-cloud-native:nutanix-failuredomains
Dec 8, 2023
Merged

SPLAT-1272: Modify the terraform variables to support Nutanix Failure Domains#7806
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
nutanix-cloud-native:nutanix-failuredomains

Conversation

@yanhua121
Copy link
Contributor

@yanhua121 yanhua121 commented Dec 6, 2023

SPLAT-1272: Modify the terraform variables to support Nutanix Failure Domains

For terraform to create the control-plane node VMs with different configurations from the Nutanix Failure Domains, the Nutanix terraform variables need to have the corresponding changes.

Related merged PRs:
#7730

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 6, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 6, 2023

@yanhua121: This pull request references SPLAT-1272 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

Details

In response to this:

SPLAT-1272: Modify the terraform variables to support Nutanix Failure Domains

For terraform to create the control-plane node VMs with different configurations from the Nutanix Failure Domains, the Nutanix terraform variables need to have the corresponding changes.

Related merged PRs:
#7730

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 6, 2023

@yanhua121: This pull request references SPLAT-1272 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

Details

In response to this:

SPLAT-1272: Modify the terraform variables to support Nutanix Failure Domains

For terraform to create the control-plane node VMs with different configurations from the Nutanix Failure Domains, the Nutanix terraform variables need to have the corresponding changes.

Related merged PRs:
#7730

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from rvanderp3 and sadasu December 6, 2023 19:03
@yanhua121 yanhua121 force-pushed the nutanix-failuredomains branch from c330ae5 to e89afe0 Compare December 6, 2023 21:27
@yanhua121
Copy link
Contributor Author

/retest-required

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 805e41a and 2 for PR HEAD e89afe0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 46fd662 and 1 for PR HEAD e89afe0 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

@yanhua121: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e44ef17 into openshift:master Dec 8, 2023
@yanhua121
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@yanhua121: new pull request created: #7813

Details

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202312081851.p0.ge44ef17.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants