Skip to content

CNF-10170: bootkube.sh: Render kernel boot arguments for SNO #7692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jan 31, 2024
Merged

CNF-10170: bootkube.sh: Render kernel boot arguments for SNO #7692

openshift-merge-bot merged 1 commit into from
Jan 31, 2024

Conversation

@jlojosnegros
Copy link
Contributor

@jlojosnegros jlojosnegros commented Nov 7, 2023 •
edited
Loading

In an effort to speed up installation and avoid node reboots this command will run tuneD on a properly isolated environment and render a MachineConfig to apply the kernel boot args readed from /etc/tuned/bootcmdline

see: openshift/cluster-node-tuning-operator#844
reverted by: #7979

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jlojosnegros jlojosnegros mentioned this pull request Nov 7, 2023
Merged
@jlojosnegros jlojosnegros force-pushed the reduce-reboots branch 2 times, most recently from df84ca6 to c9bbf57 Compare November 8, 2023 08:57
vitus133
vitus133 reviewed Nov 9, 2023
View reviewed changes
vitus133
vitus133 reviewed Nov 9, 2023
View reviewed changes
vitus133
vitus133 reviewed Nov 9, 2023
View reviewed changes
@jlojosnegros jlojosnegros marked this pull request as ready for review November 14, 2023 10:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2023
@openshift-ci openshift-ci bot requested review from jhixson74 and sadasu November 14, 2023 11:01
@jlojosnegros jlojosnegros changed the title bootkube.sh: Render kernel boot arguments for SNO CNF-10170: bootkube.sh: Render kernel boot arguments for SNO Nov 14, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 14, 2023 •
edited by openshift-ci bot
Loading

@jlojosnegros: This pull request references CNF-10170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

In an effort to speed up installation and avoid node reboots this command will run tuneD on a properly isolated environment and render a MachineConfig to apply the kernel boot args readed from /etc/tuned/bootcmdline

see: openshift/cluster-node-tuning-operator#844

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vitus133
Copy link

vitus133 commented Nov 15, 2023

Yep, looks good :)

@openshift-ci openshift-ci bot requested review from imiller0 and removed request for imiller0 November 15, 2023 08:10
@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Nov 17, 2023

/test e2e-aws-ovn

@jlojosnegros jlojosnegros force-pushed the reduce-reboots branch 2 times, most recently from 3e44335 to c4800c9 Compare November 23, 2023 11:19
@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Nov 27, 2023

/test okd-e2e-aws-ovn-upgrade

@MarSik
Copy link

MarSik commented Dec 7, 2023

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 7, 2023
@MarSik
Copy link

MarSik commented Dec 7, 2023

Ups, wrong PR, sorry

/unlabel acknowledge-critical-fixes-only

MarSik
MarSik reviewed Dec 11, 2023
View reviewed changes
vitus133
vitus133 reviewed Dec 12, 2023
View reviewed changes
Copy link

@vitus133 vitus133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion for mitigating https://issues.redhat.com/browse/CNF-10610

@MarSik
Copy link

MarSik commented Dec 15, 2023

/retest-required

@MarSik
Copy link

MarSik commented Dec 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Dec 18, 2023

/assign @jhixson74

@jlojosnegros
bootkube.sh: Render kernel boot arguments for SNO
e506646 
In an effort to speed up installation and avoid node reboots this
command will run `tuneD` on a properly isolated environment and render a
MachineConfig to apply the kernel boot args readed from
`/etc/tuned/bootcmdline`

Signed-off-by: Jose Luis Ojosnegros Manchón <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@vitus133
Copy link

vitus133 commented Jan 8, 2024

/cc @eggfoobar

@openshift-ci openshift-ci bot requested a review from eggfoobar January 8, 2024 17:12
@eggfoobar
Copy link
Contributor

eggfoobar commented Jan 9, 2024

/retest-required

@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Jan 9, 2024

/retest

@eggfoobar
Copy link
Contributor

eggfoobar commented Jan 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@eggfoobar
Copy link
Contributor

eggfoobar commented Jan 17, 2024

/hold

Adding a hold label as a precaution for now due to the discussion in this thread. We will need to handle bootstrap in place installs when no Performance Profiles are present during the tuned render

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@jhixson74
Copy link
Member

jhixson74 commented Jan 17, 2024

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@jlojosnegros jlojosnegros mentioned this pull request Jan 19, 2024
Closed
@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Jan 24, 2024

/hold

Adding a hold label as a precaution for now due to the discussion in this thread. We will need to handle bootstrap in place installs when no Performance Profiles are present during the tuned render

After openshift/cluster-node-tuning-operator#924 hold could be cancelled.
WDYT @eggfoobar ?

@eggfoobar
Copy link
Contributor

eggfoobar commented Jan 24, 2024

Sounds good to me!

@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Jan 31, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 45a3d25 into openshift:master Jan 31, 2024
@jlojosnegros jlojosnegros mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@sadasu sadasu Awaiting requested review from sadasu

@eggfoobar eggfoobar Awaiting requested review from eggfoobar

2 more reviewers

@MarSik MarSik MarSik left review comments

@vitus133 vitus133 vitus133 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@MarSik MarSik

@jhixson74 jhixson74

@eggfoobar eggfoobar

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jlojosnegros @openshift-ci-robot @vitus133 @MarSik @eggfoobar @jhixson74