CNF-10170: Render MC without additional PP

[jlojosnegros]

This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory.

So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP

[yanirq]

The meaning of "additional" is a bit obscured here ? Can we use the render command without a performance profile at all ?

[jlojosnegros]

The meaning of "additional" is a bit obscured here ? Can we use the render command without a performance profile at all ?

Well per the last discussion we had, yes.
This render command should render a MC with the kernel args from all available sources.
PerformanceProfile is another source but not a mandatory one.

Please @MarSik keep me honest here.

[MarSik]

@yanirq Yep, it is a tuned render after all. We only need to know the perf profiles to be able to collect all the generated tuned objects. But when there are no extra tuneds, NTO still ships the stock openshift-node Tuned with the proper recommendation selectors.

So the logic still works fine, even though there are no extra kernel args atm.

[MarSik]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlojosnegros, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MarSik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jlojosnegros]

/test e2e-aws-ovn-techpreview

[jlojosnegros]

/test e2e-gcp-pao-updating-profile

[openshift-ci-robot]

@jlojosnegros: This pull request references CNF-10170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead.

Details

In response to this:

This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory.

So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fd8b0be and 2 for PR HEAD a50a527 in total

[jlojosnegros]

/hold
Need to rebase once #929 is merged.

[jlojosnegros]

/hold cancel
as #929 has been already merged.

[jlojosnegros]

/test e2e-gcp-pao-updating-profile

[jlojosnegros]

/label acknowledge-critical-fixes-only

[openshift-ci]

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202401302041.p0.g74ecaaa.assembly.stream for distgit cluster-node-tuning-operator.
All builds following this will include this PR.