OCPBUGS-22095: Add default MCP objects for rendering #833

eggfoobar · 2023-10-18T22:47:05Z

added ability to use the default rmaster worker mcp labels for rendering during boostrap

/hold

pkg/performanceprofile/controller/performanceprofile/components/consts.go

pkg/performanceprofile/cmd/render/render.go

MarSik · 2023-10-19T06:38:28Z

@eggfoobar I like the direction, but we should open a bug for this to allow backports and probably make the commit messages a bit nicer.

MarSik · 2023-10-19T07:26:14Z

/retitle OCPBUGS-22095: [WIP] Add default MCP objects for rendering

openshift-ci-robot · 2023-10-19T07:26:23Z

@eggfoobar: This pull request references Jira Issue OCPBUGS-22095, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

added ability to use the default rmaster worker mcp labels for rendering during boostrap

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MarSik · 2023-10-19T07:27:01Z

/jira refresh

openshift-ci-robot · 2023-10-19T07:27:08Z

@MarSik: This pull request references Jira Issue OCPBUGS-22095, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gsr-shanks

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/performanceprofile/cmd/render/render.go

pkg/util/manifests.go

pkg/performanceprofile/cmd/render/render.go

jlojosnegros · 2024-01-17T11:56:05Z

I will prefer a better error handling than returning "ok" when there is no PP but other than that LGTM.

Signed-off-by: ehila <[email protected]>

openshift-ci · 2024-01-17T15:14:35Z

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

MarSik

/lgtm

ffromani · 2024-01-17T15:31:26Z

/lgtm

openshift-ci · 2024-01-17T15:31:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [MarSik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ffromani · 2024-01-17T15:31:50Z

/cc @jmencak

because it impacts non-perfprof code

ffromani · 2024-01-17T15:32:27Z

/hold

jmencak · 2024-01-17T15:54:05Z

/cc @jmencak

because it impacts non-perfprof code

Thank you Francesco. I don't have a problem with this change.
/hold cancel

openshift-ci-robot · 2024-01-17T15:56:56Z

@eggfoobar: Jira Issue OCPBUGS-22095: All pull requests linked via external trackers have merged:

openshift/cluster-node-tuning-operator#833

Jira Issue OCPBUGS-22095 has been moved to the MODIFIED state.

Details

In response to this:

added ability to use the default rmaster worker mcp labels for rendering during boostrap

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-01-17T19:46:08Z

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202401171849.p0.g098f41e.assembly.stream for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

MarSik · 2024-01-22T12:12:20Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2024-01-22T12:13:29Z

@MarSik: #833 failed to apply on top of branch "release-4.15":

Applying: feat: update render command to create default MCPs
Applying: feat: add default mcpools to tuned renderer
Using index info to reconstruct a base tree...
M	pkg/tuned/cmd/render/render.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/tuned/cmd/render/render.go
CONFLICT (content): Merge conflict in pkg/tuned/cmd/render/render.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 feat: add default mcpools to tuned renderer
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* feat: update render command to create default MCPs added default MCP creation to help correctly render out the resources for performance profile to use Signed-off-by: ehila <[email protected]> upkeep: fix spelling Signed-off-by: ehila <[email protected]> * feat: add default mcpools to tuned renderer Signed-off-by: ehila <[email protected]> --------- Signed-off-by: ehila <[email protected]>

* NTO: Add MCP name to filter PP (#878) render-bootcmd-mc can only compute the kernel args for a MachineConfigPool that matches the node it is executed on, so we add the MachineConfigPool name as input parameter to filter the applicable PerformanceProfiles. Signed-off-by: Jose Luis Ojosnegros Manchón <[email protected]> * OCPBUGS-22095: Add default MCP objects for rendering (#833) * feat: update render command to create default MCPs added default MCP creation to help correctly render out the resources for performance profile to use Signed-off-by: ehila <[email protected]> upkeep: fix spelling Signed-off-by: ehila <[email protected]> * feat: add default mcpools to tuned renderer Signed-off-by: ehila <[email protected]> --------- Signed-off-by: ehila <[email protected]> * Enhance render sync to include bootstrap rendering tests * Render MC without additional PP This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory. So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP Signed-off-by: Jose Luis Ojosnegros Manchón <[email protected]> * Render sync --------- Signed-off-by: Jose Luis Ojosnegros Manchón <[email protected]> Signed-off-by: ehila <[email protected]> Co-authored-by: Jose Luis Ojosnegros <[email protected]> Co-authored-by: E Hila <[email protected]>

…ift#928) * NTO: Add MCP name to filter PP (openshift#878) render-bootcmd-mc can only compute the kernel args for a MachineConfigPool that matches the node it is executed on, so we add the MachineConfigPool name as input parameter to filter the applicable PerformanceProfiles. Signed-off-by: Jose Luis Ojosnegros Manchón <[email protected]> * OCPBUGS-22095: Add default MCP objects for rendering (openshift#833) * feat: update render command to create default MCPs added default MCP creation to help correctly render out the resources for performance profile to use Signed-off-by: ehila <[email protected]> upkeep: fix spelling Signed-off-by: ehila <[email protected]> * feat: add default mcpools to tuned renderer Signed-off-by: ehila <[email protected]> --------- Signed-off-by: ehila <[email protected]> * Enhance render sync to include bootstrap rendering tests * Render MC without additional PP This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory. So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP Signed-off-by: Jose Luis Ojosnegros Manchón <[email protected]> * Render sync --------- Signed-off-by: Jose Luis Ojosnegros Manchón <[email protected]> Signed-off-by: ehila <[email protected]> Co-authored-by: Jose Luis Ojosnegros <[email protected]> Co-authored-by: E Hila <[email protected]>

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023

openshift-ci bot requested review from jlojosnegros and swatisehgal October 18, 2023 22:47

eggfoobar force-pushed the fix-bootstrap-no-mcp-render branch from 6795b56 to 085b2c6 Compare October 19, 2023 02:08

eggfoobar changed the title ~~fix: add default MCP objects for rendering~~ [WIP] fix: add default MCP objects for rendering Oct 19, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2023

MarSik reviewed Oct 19, 2023

View reviewed changes

pkg/performanceprofile/controller/performanceprofile/components/consts.go Outdated Show resolved Hide resolved

MarSik reviewed Oct 19, 2023

View reviewed changes

pkg/performanceprofile/cmd/render/render.go Outdated Show resolved Hide resolved

openshift-ci bot changed the title ~~[WIP] fix: add default MCP objects for rendering~~ OCPBUGS-22095: [WIP] Add default MCP objects for rendering Oct 19, 2023

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Oct 19, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 19, 2023

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 19, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 19, 2023

openshift-ci bot requested a review from gsr-shanks October 19, 2023 07:27

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2023

eggfoobar force-pushed the fix-bootstrap-no-mcp-render branch from 085b2c6 to 800c055 Compare January 8, 2024 12:12

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024

ffromani reviewed Jan 8, 2024

View reviewed changes

pkg/performanceprofile/cmd/render/render.go Outdated Show resolved Hide resolved

ffromani reviewed Jan 9, 2024

View reviewed changes

pkg/util/manifests.go Outdated Show resolved Hide resolved

eggfoobar force-pushed the fix-bootstrap-no-mcp-render branch from 91c935e to d8645e9 Compare January 9, 2024 21:02

vitus133 reviewed Jan 10, 2024

View reviewed changes

pkg/performanceprofile/cmd/render/render.go Show resolved Hide resolved

ffromani reviewed Jan 10, 2024

View reviewed changes

pkg/performanceprofile/cmd/render/render.go Outdated Show resolved Hide resolved

eggfoobar force-pushed the fix-bootstrap-no-mcp-render branch from d8645e9 to 90d2bca Compare January 10, 2024 10:15

feat: add default mcpools to tuned renderer

1d3c5c3

Signed-off-by: ehila <[email protected]>

eggfoobar force-pushed the fix-bootstrap-no-mcp-render branch from d1f5f59 to 1d3c5c3 Compare January 17, 2024 12:34

eggfoobar mentioned this pull request Jan 17, 2024

CNF-10170: bootkube.sh: Render kernel boot arguments for SNO openshift/installer#7692

Merged

MarSik approved these changes Jan 17, 2024

View reviewed changes

openshift-ci bot assigned MarSik Jan 17, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024

openshift-ci bot requested a review from jmencak January 17, 2024 15:31

openshift-ci bot assigned ffromani Jan 17, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024

openshift-merge-bot bot merged commit 098f41e into openshift:master Jan 17, 2024

jlojosnegros mentioned this pull request Jan 19, 2024

Improve error handling in tuned render cmd #922

Closed

MarSik mentioned this pull request Jan 25, 2024

OCPBUGS-27948: Tuned rendering and MCP detection improvements #928

Merged

openshift-ci-robot mentioned this pull request Feb 14, 2024

OCPBUGS-22095: Render: Add MCSelector to missing default MCPs #956

Merged

rbaturov mentioned this pull request Feb 28, 2024

Backporting Tuned rendering and MCP detection improvements #971

Closed

OCPBUGS-22095: Add default MCP objects for rendering #833

OCPBUGS-22095: Add default MCP objects for rendering #833

Uh oh!

Conversation

eggfoobar commented Oct 18, 2023

Uh oh!

Uh oh!

Uh oh!

MarSik commented Oct 19, 2023

Uh oh!

MarSik commented Oct 19, 2023

Uh oh!

openshift-ci-robot commented Oct 19, 2023

Uh oh!

MarSik commented Oct 19, 2023

Uh oh!

openshift-ci-robot commented Oct 19, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlojosnegros commented Jan 17, 2024

Uh oh!

openshift-ci bot commented Jan 17, 2024

Uh oh!

MarSik left a comment

Choose a reason for hiding this comment

Uh oh!

ffromani commented Jan 17, 2024

Uh oh!

openshift-ci bot commented Jan 17, 2024

Uh oh!

ffromani commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ffromani commented Jan 17, 2024

Uh oh!

jmencak commented Jan 17, 2024

Uh oh!

openshift-ci-robot commented Jan 17, 2024

Uh oh!

openshift-bot commented Jan 17, 2024

Uh oh!

MarSik commented Jan 22, 2024

Uh oh!

openshift-cherrypick-robot commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

ffromani commented Jan 17, 2024 •

edited

Loading