Skip to content

Conversation

@andfasano
Copy link
Contributor

Some of the scripts generated by the create ignition-configs command for OKD may require to discriminate the cases where SNO is being managed or agent-based installer is currently used, thus adding the OPENSHIFT_INSTALL_INVOKER env var in the template inputs.

@andfasano andfasano changed the title Use invoker for bootstrap template generation AGENT-701: Use invoker for bootstrap template generation Sep 20, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2023

@andfasano: This pull request references AGENT-701 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but it targets "openshift-4.15" instead.

Details

In response to this:

Some of the scripts generated by the create ignition-configs command for OKD may require to discriminate the cases where SNO is being managed or agent-based installer is currently used, thus adding the OPENSHIFT_INSTALL_INVOKER env var in the template inputs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano andfasano changed the title AGENT-701: Use invoker for bootstrap template generation AGENT-710: Use invoker for bootstrap template generation Sep 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2023

@andfasano: This pull request references AGENT-710 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

Details

In response to this:

Some of the scripts generated by the create ignition-configs command for OKD may require to discriminate the cases where SNO is being managed or agent-based installer is currently used, thus adding the OPENSHIFT_INSTALL_INVOKER env var in the template inputs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Contributor Author

/jira-refresh

@JM1
Copy link
Contributor

JM1 commented Sep 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@bfournie
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 010d875 and 2 for PR HEAD 3bbeb3c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b2f5f80 and 1 for PR HEAD 3bbeb3c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a1e43e7 into openshift:master Sep 22, 2023
@JM1
Copy link
Contributor

JM1 commented Oct 12, 2023

@andfasano: Do we want to cherry-pick this to 4.14 (and 4.13) in order to prepare the OKD ABI fix series (e.g. #7516) for older releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants