Skip to content

Comments

OPNET-415: Upgrade o/api to include extended network config#7869

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
mkowalski:OPNET-415-2
Jan 11, 2024
Merged

OPNET-415: Upgrade o/api to include extended network config#7869
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
mkowalski:OPNET-415-2

Conversation

@mkowalski
Copy link
Contributor

Infra CR allows now to more extensive configuration of host networking (implemented as openshift/api#1695).

This PR gets those changes into the installer.

We are forcefully making k8s.io/api and k8s.io/apimachinery to stay at v0.28.3 because their bump to v0.29.0 should happen as a separate task.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 4, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 4, 2024

@mkowalski: This pull request references OPNET-415 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Infra CR allows now to more extensive configuration of host networking (implemented as openshift/api#1695).

This PR gets those changes into the installer.

We are forcefully making k8s.io/api and k8s.io/apimachinery to stay at v0.28.3 because their bump to v0.29.0 should happen as a separate task.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mkowalski
Copy link
Contributor Author

/test all

@mkowalski mkowalski marked this pull request as ready for review January 4, 2024 14:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2024
@mkowalski
Copy link
Contributor Author

/cc @JoelSpeed
/cc @cybertron

As reviewers of the o/api change

/cc @zaneb

As approver of installer

@sadasu
Copy link
Contributor

sadasu commented Jan 11, 2024

@mkowalski are additional changes required within the Installer while generating the Infra manifest for the platforms that are updated with the opnshift/api changes?

@mkowalski
Copy link
Contributor Author

are additional changes required within the Installer while generating the Infra manifest for the platforms that are updated with the opnshift/api changes?

@sadasu, once this PR with API update merges I will ask for review of #7604 which is responsible for filling the new fields.

The reason I don't do it in a single PR is that it is not mandatory to have those new fields with values immediately, thus merging the API update without code updating new values is not going to break anything

@sadasu
Copy link
Contributor

sadasu commented Jan 11, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbethell-1, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

@mkowalski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0604a58 into openshift:master Jan 11, 2024
@mkowalski mkowalski deleted the OPNET-415-2 branch January 12, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants