OPNET-415: Upgrade o/api to include extended network config#7869
OPNET-415: Upgrade o/api to include extended network config#7869openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
Conversation
|
@mkowalski: This pull request references OPNET-415 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
/cc @JoelSpeed As reviewers of the o/api change /cc @zaneb As approver of installer |
|
@mkowalski are additional changes required within the Installer while generating the Infra manifest for the platforms that are updated with the opnshift/api changes? |
@sadasu, once this PR with API update merges I will ask for review of #7604 which is responsible for filling the new fields. The reason I don't do it in a single PR is that it is not mandatory to have those new fields with values immediately, thus merging the API update without code updating new values is not going to break anything |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbethell-1, sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mkowalski: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Infra CR allows now to more extensive configuration of host networking (implemented as openshift/api#1695).
This PR gets those changes into the installer.
We are forcefully making
k8s.io/apiandk8s.io/apimachineryto stay atv0.28.3because their bump tov0.29.0should happen as a separate task.