Skip to content

OCPBUGS-4038: bootstrap: don't enable gatewayd socket on OKD #6619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vrutkovs wants to merge 1 commit into from
Closed

OCPBUGS-4038: bootstrap: don't enable gatewayd socket on OKD #6619

vrutkovs wants to merge 1 commit into from

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Nov 23, 2022

FCOS doesn't come with this service, and now assisted installer fails attempting to enable this socket

bootstrap: don't enable gatewayd socket on OKD
6386a26 
FCOS doesn't come with this service, and now assisted installer fails attempting to enable this socket
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 23, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 23, 2022

@vrutkovs: This pull request references Jira Issue OCPBUGS-4038, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

FCOS doesn't come with this service, and now assisted installer fails attempting to enable this socket

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Nov 23, 2022

/test okd-e2e-aws

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Nov 23, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 23, 2022
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Nov 23, 2022

/cherry-pick release-4.12

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 23, 2022
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 23, 2022

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 23, 2022

@vrutkovs: This pull request references Jira Issue OCPBUGS-4038, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

@vrutkovs: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test aro-unit
  • /test e2e-agent-compact
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-scos-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-agent-mce
  • /test e2e-agent-sno
  • /test e2e-alibaba
  • /test e2e-aws-ovn-disruptive
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-shared-vpc
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-upi-proxy
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-ovn-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-libvirt
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-sdn-swapped-hosts
  • /test e2e-metal-ipi-sdn-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-openstack
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-proxy
  • /test e2e-openstack-sdn-parallel
  • /test e2e-openstack-upi
  • /test e2e-ovirt-sdn
  • /test e2e-sdn-nutanix
  • /test e2e-vsphere-zones
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-ovn-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test okd-scos-e2e-aws-ovn
  • /test okd-scos-e2e-aws-upgrade
  • /test okd-scos-e2e-gcp
  • /test okd-scos-e2e-gcp-ovn-upgrade
  • /test okd-scos-e2e-vsphere
  • /test okd-scos-unit
  • /test okd-scos-verify-codegen
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-agent-compact
  • pull-ci-openshift-installer-master-e2e-agent-sno
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-aws-ovn-disruptive
  • pull-ci-openshift-installer-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-installer-master-e2e-aws-ovn-workers-rhel8
  • pull-ci-openshift-installer-master-e2e-azure-ovn
  • pull-ci-openshift-installer-master-e2e-gcp-ovn
  • pull-ci-openshift-installer-master-e2e-ibmcloud-ovn
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-assisted
  • pull-ci-openshift-installer-master-e2e-metal-ipi-sdn
  • pull-ci-openshift-installer-master-e2e-openstack
  • pull-ci-openshift-installer-master-e2e-ovirt-sdn
  • pull-ci-openshift-installer-master-e2e-vsphere-ovn
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-scos-e2e-aws-upgrade
  • pull-ci-openshift-installer-master-okd-scos-images
  • pull-ci-openshift-installer-master-okd-scos-unit
  • pull-ci-openshift-installer-master-okd-scos-verify-codegen
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

/test okd-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Nov 23, 2022

/test okd-e2e-aws-ovn

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Nov 23, 2022

/skip
/retest-required

@andfasano
Copy link
Contributor

andfasano commented Nov 28, 2022

Found this issue while trying to use OKD with agent installer, so this patch should fix it.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 2, 2022

/test e2e-vsphere-ovn

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 2, 2022

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 2, 2022

/skip

1 similar comment
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 2, 2022

/skip

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 2, 2022

/retest

1 similar comment
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 3, 2022

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 3, 2022

/skip
/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 3, 2022

/retest

2 similar comments
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 7, 2022

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 7, 2022

/retest

@sadasu
Copy link
Contributor

sadasu commented Jan 4, 2023

/approve

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Sep 18, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 18, 2023

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Sep 18, 2023

/hold cancel
yolo

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2023

/retest-required

Remaining retests: 0 against base HEAD 4e4eec6 and 2 for PR HEAD 6386a26 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2023

/retest-required

Remaining retests: 0 against base HEAD 2dc091e and 1 for PR HEAD 6386a26 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2023

/retest-required

Remaining retests: 0 against base HEAD 3a554d4 and 0 for PR HEAD 6386a26 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2023

/hold

Revision 6386a26 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
@andfasano
Copy link
Contributor

andfasano commented Sep 19, 2023

Tide seems to be stuck, trying to awake it

/jira-refresh

@LorbusChris
Copy link
Contributor

LorbusChris commented Sep 19, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
@LorbusChris
Copy link
Contributor

LorbusChris commented Sep 19, 2023

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2023

/retest-required

Remaining retests: 0 against base HEAD 3a554d4 and 2 for PR HEAD 6386a26 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2023

/retest-required

Remaining retests: 0 against base HEAD b505ddf and 1 for PR HEAD 6386a26 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2023

/retest-required

Remaining retests: 0 against base HEAD dd8d107 and 0 for PR HEAD 6386a26 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2023

/hold

Revision 6386a26 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Sep 20, 2023

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@vrutkovs vrutkovs mentioned this pull request Sep 20, 2023
Closed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2023

/retest-required

Remaining retests: 0 against base HEAD d27c250 and 2 for PR HEAD 6386a26 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2023

/retest-required

Remaining retests: 0 against base HEAD 6471b31 and 1 for PR HEAD 6386a26 in total

@LorbusChris
Copy link
Contributor

LorbusChris commented Sep 20, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno 6386a26 link false /test e2e-agent-sno
ci/prow/e2e-ovirt-sdn 6386a26 link false /test e2e-ovirt-sdn
ci/prow/okd-scos-e2e-aws-upgrade 6386a26 link false /test okd-scos-e2e-aws-upgrade
ci/prow/e2e-aws-ovn-disruptive 6386a26 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-ibmcloud-ovn 6386a26 link false /test e2e-ibmcloud-ovn
ci/prow/e2e-openstack 6386a26 link false /test e2e-openstack
ci/prow/okd-scos-e2e-aws-ovn 6386a26 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-assisted 6386a26 link false /test e2e-metal-assisted
ci/prow/e2e-libvirt 6386a26 link false /test e2e-libvirt
ci/prow/okd-e2e-aws-ovn-upgrade 6386a26 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-agent-compact 6386a26 link true /test e2e-agent-compact
ci/prow/e2e-metal-ipi-sdn 6386a26 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-upgrade 6386a26 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-workers-rhel8 6386a26 link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-agent-ha-dualstack 6386a26 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-sno-ipv6 6386a26 link false /test e2e-agent-sno-ipv6
ci/prow/okd-e2e-agent-compact-ipv4 6386a26 link false /test okd-e2e-agent-compact-ipv4
ci/prow/okd-e2e-agent-sno-ipv6 6386a26 link false /test okd-e2e-agent-sno-ipv6
ci/prow/e2e-metal-ipi-ovn-ipv6 6386a26 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn 6386a26 link true /test e2e-vsphere-ovn
ci/prow/e2e-azure-ovn 6386a26 link true /test e2e-azure-ovn
ci/prow/e2e-gcp-ovn 6386a26 link true /test e2e-gcp-ovn
ci/prow/e2e-agent-compact-ipv4 6386a26 link true /test e2e-agent-compact-ipv4
ci/prow/e2e-openstack-ovn 6386a26 link true /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn 6386a26 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LorbusChris
Copy link
Contributor

LorbusChris commented Sep 20, 2023

This work has moved to #7505
/close

@openshift-ci openshift-ci bot closed this Sep 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2023

@vrutkovs: This pull request references Jira Issue OCPBUGS-4038. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

FCOS doesn't come with this service, and now assisted installer fails attempting to enable this socket

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@LorbusChris: Closed this PR.

Details

In response to this:

This work has moved to #7505
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@gpei gpei Awaiting requested review from gpei

Assignees

@andfasano andfasano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@vrutkovs @openshift-ci-robot @openshift-cherrypick-robot @andfasano @sadasu @barbacbd @openshift-bot @JM1 @LorbusChris