Skip to content

OCPBUGS-15659: Update openshift/api to add MachineAPI update #7456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwsu wants to merge 1 commit into from
Closed

OCPBUGS-15659: Update openshift/api to add MachineAPI update #7456

rwsu wants to merge 1 commit into from

Conversation

@rwsu
Copy link
Contributor

@rwsu rwsu commented Aug 30, 2023

The ClusterVersionCapabilitySets for v4.11, v4.12, v4.13 were recently updated in openshift/api#1554 to include the MachineAPI Capability.

This change is needed to ensure the IPI MachineAPI Capability precheck work correctly for those OpenShift versions.

Fixes #7414 for v4.11, v4.12, and v.4.13.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 30, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 30, 2023

@rwsu: This pull request references Jira Issue OCPBUGS-15659, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The ClusterVersionCapabilitySets for v4.11, v4.12, v4.13 were recently updated in openshift/api#1554 to include the MachineAPI Capability.

This change is needed to ensure the IPI MachineAPI Capability precheck work correctly for those OpenShift versions.

Fixes #7414 for v4.11, v4.12, and v.4.13.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rwsu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rwsu rwsu force-pushed the OCPBUGS-15659-update-openshift-api branch from 48b040a to 244d333 Compare August 30, 2023 16:06
@rwsu
Copy link
Contributor Author

rwsu commented Aug 30, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 30, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 30, 2023

@rwsu: This pull request references Jira Issue OCPBUGS-15659, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jinyunma August 30, 2023 16:28
@rwsu
OCPBUGS-15659: Update openshift/api to add MachineAPI update
6b9fcd3 
The ClusterVersionCapabilitySets for v4.11, v4.12, v4.13 were
recently updated in openshift/api#1554
to include the MachineAPI Capability.

This change is needed to ensure the IPI MachineAPI Capability
precheck work correctly for those OpenShift versions.

Signed-off-by: Richard Su <[email protected]>
@rwsu rwsu force-pushed the OCPBUGS-15659-update-openshift-api branch from 244d333 to 6b9fcd3 Compare August 30, 2023 22:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

@rwsu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack 6b9fcd3 link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2023
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Sep 10, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rwsu
Copy link
Contributor Author

rwsu commented Sep 11, 2023

Closing. Duplicate of #7421

@rwsu rwsu closed this Sep 11, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2023

@rwsu: This pull request references Jira Issue OCPBUGS-15659. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

The ClusterVersionCapabilitySets for v4.11, v4.12, v4.13 were recently updated in openshift/api#1554 to include the MachineAPI Capability.

This change is needed to ensure the IPI MachineAPI Capability precheck work correctly for those OpenShift versions.

Fixes #7414 for v4.11, v4.12, and v.4.13.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@jinyunma jinyunma Awaiting requested review from jinyunma

Assignees

No one assigned

Labels

jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rwsu @openshift-ci-robot @openshift-merge-robot