OCPBUGS-15659: IPI pre-check for MachineAPI capability

[rwsu]

Adds a validation check to ensure that MachineAPI capability is included for IPI deployments.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@rwsu: This pull request references Jira Issue OCPBUGS-15659, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

replicas is > 0.

Adds a validation check to ensure that MachineAPI capability is included for the cluster when the number of compute replicas is greater than 0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rwsu]

/jira refresh

[openshift-ci-robot]

@rwsu: This pull request references Jira Issue OCPBUGS-15659, which is invalid:

• expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rwsu]

/jira refresh

[openshift-ci-robot]

@rwsu: This pull request references Jira Issue OCPBUGS-15659, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[patrickdillon]

/approve

[patrickdillon]

can you move this into its own import block preceding this one? I believe this will actually cause unit tests to fail (otherwise I would consider it a nit): https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#import-order

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jinyunma]

@rwsu FYI. MachineAPI is required on IPI including IPI SON, IPI compact and common IPI (3 masters + N workers). It only can be disabled in UPI cluster.
Discussion is here.

[openshift-ci-robot]

@rwsu: This pull request references Jira Issue OCPBUGS-15659, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Adds a validation check to ensure that MachineAPI capability is included for IPI deployments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rwsu]

/retest-required

[rwsu]

/retest-required

[rwsu]

/retest-required

[bfournie]

/lgtm

[openshift-ci]

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@rwsu: Jira Issue OCPBUGS-15659: All pull requests linked via external trackers have merged:

• openshift/installer#7414

Jira Issue OCPBUGS-15659 has been moved to the MODIFIED state.

Details

In response to this:

Adds a validation check to ensure that MachineAPI capability is included for IPI deployments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.