Bump & vendor k8s 1.27 dependencies #7220
Conversation
The most recent k8s api bump requires a context is passed to the wait.ExponentialBackoffWithContext function.
metal3-io/baremetal-operator@6c1abd0 moved the hardware profile package to the api. This commit points to the new package locations.
patrickdillon
force-pushed
the
bump-414-apis
branch
from
370a363 to
dfef0a5
Compare
$ go mod edit \ -replace=github.com/metal3-io/baremetal-operator=github.com/openshift/baremetal-operator@master \ -replace=github.com/metal3-io/baremetal-operator/apis=github.com/openshift/baremetal-operator/apis@master \ -replace=github.com/metal3-io/baremetal-operator/pkg/hardwareutils=github.com/openshift/baremetal-operator/pkg/hardwareutils@master $ go mod edit -require=github.com/openshift/api@master $ go mod edit -replace=github.com/openshift/api=github.com/openshift/api@master $ go mod edit -replace k8s.io/client-go=k8s.io/[email protected] (with $ go mod tidy run between each command)
Bumps core Installer to Go v1.20. Terraform and providers will be updated separately.
Fixes deprecation issue: pkg/destroy/vsphere/vsphere.go:243:9: SA1019: wait.PollImmediateInfiniteWithContext is deprecated: This method does not return errors from context, use PollWithContextCancel. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
$ go mod vendor
Update generated CRD for explain after API vendoring. $ go generate ./pkg/types/installconfig.go
patrickdillon
force-pushed
the
bump-414-apis
branch
from
dfef0a5 to
4dd6811
Compare
|
/test ci/prow/openstack-manifests |
|
@patrickdillon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test openstack-manifests |
|
The |
@WenXinWei please review the failure since this started after the merge of #6999 |
|
I have looked through all of the failures so far, and none of them look concerning or related to the changes at hand. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mrunalp
added
the
jira/valid-bug
|
/override ci/prow/e2e-aws-ovn-upi ci/prow/e2e-vsphere-upi |
|
/skip |
installs succeeded failures look like flakes and are unrelated to current changes |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws-ovn-upi, ci/prow/e2e-vsphere-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-azure-ovn-upi |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-azure-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hi @jcpowermac , please help review and merge pr 39916. then 6999 will not block upi zone installation. |
5 participants
Pulls in most recent openshift/api and bumps v0.27.2 libraries.
For compatibility, update:
wait.ExponentialBackoffWithContextwait.PollImmediateInfiniteWithContextin vSphere destroyTerraform & providers can be updated to Go v1.20 separately.