OCPBUGS-10306: [vSphere] Upi installation failed due to VMs for master and worker node creation failed

[WenXinWei]

Terraform will not create VMs for master and worker for upi vsphere when unset var.control_plane_ip_addresses and var.compute_ip_addresses. When users are using IPAM (as before) to reserve IPs instead of setting static IPs directly into var.control_plane_ip_addresses and var.compute_ip_addresses, Based on upstream code #1 and #2. The count of master and worker is always 0, then terraform will not create any VMs for master and worker nodes. If we changed code as below, it works in IPAM case as before.  
control_plane_fqdns = [for idx in range(length(var.control_plane_ip_addresses)) : "control-plane-${idx}.${var.cluster_domain}"]  
compute_fqdns = [for idx in range(length(var.compute_ip_addresses)) : "compute-${idx}.${var.cluster_domain}"] ==>>
control_plane_fqdns = [for idx in range(var.control_plane_count) : "control-plane-${idx}.${var.cluster_domain}"]
compute_fqdns = [for idx in range(var.compute_count) : "compute-${idx}.${var.cluster_domain}"]

[WenXinWei]

also cc @rvanderp3 for review. thanks

[WenXinWei]

/test e2e-vsphere-upi-zones

[r4f4]

/retitle OCPBUGS-10306: [vSphere] Upi installation failed due to VMs for master and worker node creation failed

[openshift-ci-robot]

@WenXinWei: This pull request references Jira Issue OCPBUGS-10306, which is invalid:

• expected the bug to target only the "4.14.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Terraform will not create VMs for master and worker for upi vsphere when unset var.control_plane_ip_addresses and var.compute_ip_addresses. When users are using IPAM (as before) to reserve IPs instead of setting static IPs directly into var.control_plane_ip_addresses and var.compute_ip_addresses, Based on upstream code #1 and #2. The count of master and worker is always 0, then terraform will not create any VMs for master and worker nodes. If we changed code as below, it works in IPAM case as before.  
control_plane_fqdns = [for idx in range(length(var.control_plane_ip_addresses)) : "control-plane-${idx}.${var.cluster_domain}"]  
compute_fqdns = [for idx in range(length(var.compute_ip_addresses)) : "compute-${idx}.${var.cluster_domain}"] ==>>
control_plane_fqdns = [for idx in range(var.control_plane_count) : "control-plane-${idx}.${var.cluster_domain}"]
compute_fqdns = [for idx in range(var.compute_count) : "compute-${idx}.${var.cluster_domain}"]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[r4f4]

/jira refresh

[openshift-ci-robot]

@r4f4: This pull request references Jira Issue OCPBUGS-10306, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[r4f4]

@WenXinWei the terraform configs look broken for the e2e-vsphere-upi-zones job:

 2023-03-27 07:28:54+00:00 - terraform apply...
Error: Error in function call
  on main.tf line 163, in module "compute_a_records":
 163:    records = zipmap(local.compute_fqdns, module.ipam_compute.ip_addresses)
    ├────────────────
    │ local.compute_fqdns is tuple with 3 elements
    │ module.ipam_compute.ip_addresses is list of string with 4 elements
Call to function "zipmap" failed: number of keys (3) does not match number of
values (4). 

[jcpowermac]

Why do we still need to use IPAM? We should be using the static range in each segment like all of other CI jobs.
IPAM is another piece of infrastructure we should not be managing still.

[WenXinWei]

Why do we still need to use IPAM? We should be using the static range in each segment like all of other CI jobs. IPAM is another piece of infrastructure we should not be managing still.

We still have some jobs , The manual installation needs to be executed in qe-segment/discon-segment. In this case, the ci method cannot be reused, because multiple clusters may need to be run at the same time, So the ipam is still required

[WenXinWei]

/test e2e-vsphere-upi-zones

[WenXinWei]

@jcpowermac @rvanderp3 Could you please help to merge this pr first? now only step 'e2e-vsphere-upi-zones' failed, the issue can refer to comments but in the merged PR 38241, I missed to assign MASTER_REPLICA/WORKER_REPLICA to control_plane_count/compute_count. if i create a new pr to update, it will blocked by this pr(control_plane_count and compute_count not updated yet), so i think this pr need to be approved first.

[jcpowermac]

I am still not fond of the use of IPAM and an alternate method of IP allcation should be used.

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• upi/vsphere/OWNERS [jcpowermac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3bf878a and 2 for PR HEAD 2c31650 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d50f489 and 1 for PR HEAD 2c31650 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4c00531 and 0 for PR HEAD 2c31650 in total

[openshift-ci-robot]

/hold

Revision 2c31650 was retested 3 times: holding

[WenXinWei]

/hold cancel
/retest-required

[WenXinWei]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c2b00a8 and 2 for PR HEAD 2c31650 in total

[openshift-ci]

@WenXinWei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-workers-rhel8	2c31650	link	false	/test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-aws-ovn-upgrade	2c31650	link	false	/test e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-upi-zones	2c31650	link	false	/test e2e-vsphere-upi-zones

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2652c68 and 1 for PR HEAD 2c31650 in total

[openshift-ci-robot]

@WenXinWei: Jira Issue OCPBUGS-10306: All pull requests linked via external trackers have merged:

• openshift/installer#6999

Jira Issue OCPBUGS-10306 has been moved to the MODIFIED state.

Details

In response to this:

Terraform will not create VMs for master and worker for upi vsphere when unset var.control_plane_ip_addresses and var.compute_ip_addresses. When users are using IPAM (as before) to reserve IPs instead of setting static IPs directly into var.control_plane_ip_addresses and var.compute_ip_addresses, Based on upstream code #1 and #2. The count of master and worker is always 0, then terraform will not create any VMs for master and worker nodes. If we changed code as below, it works in IPAM case as before.  
control_plane_fqdns = [for idx in range(length(var.control_plane_ip_addresses)) : "control-plane-${idx}.${var.cluster_domain}"]  
compute_fqdns = [for idx in range(length(var.compute_ip_addresses)) : "compute-${idx}.${var.cluster_domain}"] ==>>
control_plane_fqdns = [for idx in range(var.control_plane_count) : "control-plane-${idx}.${var.cluster_domain}"]
compute_fqdns = [for idx in range(var.compute_count) : "compute-${idx}.${var.cluster_domain}"]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcpowermac]

@WenXinWei this broke zones

[WenXinWei]

@WenXinWei this broke zones

yes, because i have another change need to be merged. after pr merged , it should be ok.

[WenXinWei]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@WenXinWei: new pull request created: #7229

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.