Skip to content

Update openshift/api to latest #7071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Karthik-K-N wants to merge 1 commit into from
Closed

Update openshift/api to latest #7071

Karthik-K-N wants to merge 1 commit into from

Conversation

@Karthik-K-N
Copy link
Member

@Karthik-K-N Karthik-K-N commented Apr 6, 2023

To support cluster-control-plane-machine-set-operator to Power VS platform PowerVS provider spec is updated via PR: openshift/api#1415.

This PR updates openshift/api to latest version to fetch the newly added fields.

@openshift-ci openshift-ci bot requested review from AnnaZivkovic and r4f4 April 6, 2023 06:50
@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Apr 6, 2023

/retest-required

1 similar comment
@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Apr 10, 2023

/retest-required

r4f4
r4f4 reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023
@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Apr 18, 2023

/retest-required

2 similar comments
@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Apr 24, 2023

/retest-required

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Apr 26, 2023

/retest-required

@AnnaZivkovic
Copy link

AnnaZivkovic commented Apr 26, 2023

/retest

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Apr 28, 2023

/retest-required

3 similar comments
@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented May 4, 2023

/retest-required

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented May 8, 2023

/retest-required

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented May 9, 2023

/retest-required

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented May 16, 2023

/retetst

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from r4f4. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented May 22, 2023

/retest-required

@r4f4
Copy link
Contributor

r4f4 commented May 22, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

@Karthik-K-N: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade fe8d3c6 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-ovn-xpn fe8d3c6 link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-agent-ha-dualstack fe8d3c6 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-openstack-sdn-parallel fe8d3c6 link false /test e2e-openstack-sdn-parallel
ci/prow/e2e-gcp-secureboot fe8d3c6 link false /test e2e-gcp-secureboot
ci/prow/e2e-gcp-ovn fe8d3c6 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Jun 1, 2023

This should now be covered by #7220

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2023
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jun 1, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Jun 2, 2023

/close

Closing this as another PR #7220 got merged and which updates the openshift/api

@Karthik-K-N Karthik-K-N closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

1 more reviewer

@r4f4 r4f4 r4f4 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@r4f4 r4f4

Labels

lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Karthik-K-N @AnnaZivkovic @r4f4 @openshift-merge-robot