Dockerfile.rhel7 to run installation from RHEL

[e-minguez]

It uses regular RHEL7 to build the installer and rhel7-minimal to run it.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: e-minguez
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinavdahiya]

@smarterclayton added this openshift/machine-config-operator#165

I think we want something similar ie. minial changes to https://github.com/openshift/installer/blob/master/images/installer/Dockerfile.ci to make it rhel

[smarterclayton]

The new standard docker file will enforce in CI the rules that allow teams to ensure their product images match. Basically, you can only install RPMs from the build repos (provided in the base image) and you have to follow the pattern and conventions (so we can get reasonably close to generating it from inputs).

Images definitely need to be in the builder / base format, using the FROM lines in the other Dockerfiles. The builder image should use the standard directory for go, and can't bring in any dependencies that aren't in RPMs (already packaged as part of our build system) or not vendored in tree (anything go gettable or curled).

[e-minguez]

The new standard docker file will enforce in CI the rules that allow teams to ensure their product images match. Basically, you can only install RPMs from the build repos (provided in the base image) and you have to follow the pattern and conventions (so we can get reasonably close to generating it from inputs).

Images definitely need to be in the builder / base format, using the FROM lines in the other Dockerfiles. The builder image should use the standard directory for go, and can't bring in any dependencies that aren't in RPMs (already packaged as part of our build system) or not vendored in tree (anything go gettable or curled).

The thing is, right now, there is no golang 1.10 nor dep available in RHEL7 as packages.

This PR was about to add a Dockerfile for users that want to build the installer in his RHEL based environment, but it can be closed if it is not useful.

[wking]

The thing is, right now, there is no golang 1.10 nor dep available in RHEL7 as packages.

#723 is enabling some RPM repositories (I think?) to get Go 1.10 on RHEL (7?). If we expect to build the installer on RHEL, is that approach sufficient? Or is there a timeline for when Go 1.10 will become more easily available on RHEL? Or can we patch k8s.io/client-go to drop its strings.Builder so it compiles on Go 1.9?

[wking]

The builder image should use the standard directory for go, and can't bring in any dependencies that aren't in RPMs (already packaged as part of our build system) or not vendored in tree (anything go gettable or curled).

Is anybody planning on packaging Terraform (and the plugins we need) into RPMs?

[openshift-ci-robot]

@e-minguez: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	bf16c47	link	/test e2e-aws
ci/prow/e2e-libvirt	bf16c47	link	/test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[smarterclayton]

It would be a better outcome for you to vendor terraform than trying to do RPMs, especially if you expect to rev it multiple times. RPMs are a lot of work when you are trying to iterate quickly. You won't get PR testing. You'll have a different structure on disk in the final image. It's just not worth it if you are changing it rapidly.

[wking]

... especially if you expect to rev it multiple times...

I don't think we expect to need to bump Terraform frequently.

[abhinavdahiya]

filed #903 with a more smaller rhel7 dockerfile

[wking]

Obsoleted by #903.

/close

[openshift-ci-robot]

@wking: Closed this PR.

Details

In response to this:

Obsoleted by #903.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.