Skip to content

Add a RHEL7 dockerfile and standarize format #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 14, 2018
Merged

Add a RHEL7 dockerfile and standarize format #165

openshift-merge-robot merged 1 commit into from
Nov 14, 2018

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Nov 11, 2018

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2018
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Nov 12, 2018

/retest

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Nov 12, 2018

the tests are green, @ashcrow do you have any concerns? otherwise i'll /lgtm

cgwalters
cgwalters reviewed Nov 12, 2018
View reviewed changes
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Nov 13, 2018

/retest

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Nov 13, 2018

e2e-failure openshift/cluster-network-operator#32

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Nov 13, 2018

/retest

@ashcrow
Copy link
Member

ashcrow commented Nov 13, 2018

Same flake as noted above.

/test e2e-aws

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2018
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c39289b into openshift:master Nov 14, 2018
@abhinavdahiya abhinavdahiya mentioned this pull request Nov 14, 2018
Merged
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 15, 2018

Tests went green, what would be the most unambiguous signal that the MCD was working (besides a generic crashloopnig test that we will add)?

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Nov 15, 2018

The OS team has been planning some e2e test for the daemon. that should catch these. cc @ashcrow

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 15, 2018

I've got a "are any pods in the core suites crash looping" e2e test coming up that will be in the guard suites.

@abhinavdahiya abhinavdahiya mentioned this pull request Nov 20, 2018
Closed
@abhinavdahiya abhinavdahiya mentioned this pull request Dec 13, 2018
Merged
abhinavdahiya added a commit to abhinavdahiya/installer that referenced this pull request Dec 14, 2018
@abhinavdahiya
image: Add a RHEL7 dockerfile and standarize format
97482d5 
This is similar to various PRs opened in openshift repos like openshift/machine-config-operator#165
to help standarize the dockerfiles

also remove the `COPY --from builder <terraform>` instructions that were missed in aff2e98
osherdp pushed a commit to osherdp/machine-config-operator that referenced this pull request Apr 13, 2021
@openshift-merge-robot
Merge pull request openshift#165 from gabemontero/degraded-imp-err-2-hr
dcbeb38 
Bug 1738256: report clusteroperator degraded if image import persists for 2 hours
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters cgwalters left review comments

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@crawford crawford Awaiting requested review from crawford

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@smarterclayton @openshift-ci-robot @abhinavdahiya @ashcrow @openshift-bot @cgwalters @openshift-merge-robot