-
Notifications
You must be signed in to change notification settings - Fork 1.5k
installer needs go 1.10 #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #621, which is coming at this from a different direction. Do we know what the RHEL/CentOS support policy is for Go? Are they still maintaining 1.9 and earlier releases after upstream has dropped support for them? My preferred approach is still to have folks use a CI-tested Dockerfile to build in a container when their host has build problems of any kind. If folks want to land hacks to work around outdated RHEL/CentOS packages, I'd like to have a clearer picture around the RHEL/CentOS lifecycle plans for those outdated packages so I can understand how portable these proposed workarounds are.
docs/dev/dependencies.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line applies to Fedora as well. I'm not sure how to restructure your suggestion to preserve that, aside from copy/pasting to it shows up in both sections.
71c4084 to
85e162d
Compare
|
Hi, created a new section for the libvirt dependency. Also split CentOS and RHEL instructions because they are in fact different and I overlooked that initially. Just tested CentOS and we are using another SCL package because I don't see it in CentOS repos. While RHEL has both but I see better documented the one I have put originally in the doc.
#621 is nice. Still we need to document how to provide necessary Go version on RHEL and CentOS.
All RHEL 7 packages from base repo have the same support policy AFAIK. For example still git 1.8 in main repo. SCL packages are newer and with shorter lifecycle. FYI things may work differently with future versions of RHEL, I know no details yet.
I see no build problems. Just this is the way required packages are to be installed on RHEL and CentOS. Building in containers is fine with me. We still need to ensure installer works on RHEL with officially supported packages because this will be the usage we support once we start providing support for the new installer (and this is not a matter of preference but of support policies).
Using supported and documented way to get packages on RHEL is no hack.
For support policy see https://access.redhat.com/support/policy/updates/errata/ |
445a483 to
d74718d
Compare
|
bump, anything not addressed? |
|
bump |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akostadinov If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@akostadinov: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
error cannot have anything to do with pull request |
|
closing due to inactivity. Please reopen if needed. /close |
|
@abhinavdahiya: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
With 1.9 that comes with RHEL by default, things fail with
undefined: strings.Builder.