Skip to content

Conversation

@akostadinov
Copy link

@akostadinov akostadinov commented Nov 24, 2018

With 1.9 that comes with RHEL by default, things fail with undefined: strings.Builder.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 24, 2018
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #621, which is coming at this from a different direction. Do we know what the RHEL/CentOS support policy is for Go? Are they still maintaining 1.9 and earlier releases after upstream has dropped support for them? My preferred approach is still to have folks use a CI-tested Dockerfile to build in a container when their host has build problems of any kind. If folks want to land hacks to work around outdated RHEL/CentOS packages, I'd like to have a clearer picture around the RHEL/CentOS lifecycle plans for those outdated packages so I can understand how portable these proposed workarounds are.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line applies to Fedora as well. I'm not sure how to restructure your suggestion to preserve that, aside from copy/pasting to it shows up in both sections.

@akostadinov
Copy link
Author

akostadinov commented Nov 26, 2018

Hi, created a new section for the libvirt dependency. Also split CentOS and RHEL instructions because they are in fact different and I overlooked that initially. Just tested CentOS and we are using another SCL package because I don't see it in CentOS repos. While RHEL has both but I see better documented the one I have put originally in the doc.

See also #621, which is coming at this from a different direction.

#621 is nice. Still we need to document how to provide necessary Go version on RHEL and CentOS.

Are they still maintaining 1.9 and earlier releases after upstream has dropped support for them?

All RHEL 7 packages from base repo have the same support policy AFAIK. For example still git 1.8 in main repo. SCL packages are newer and with shorter lifecycle. FYI things may work differently with future versions of RHEL, I know no details yet.

My preferred approach is still to have folks use a CI-tested Dockerfile to build in a container when their host has build problems of any kind.

I see no build problems. Just this is the way required packages are to be installed on RHEL and CentOS. Building in containers is fine with me. We still need to ensure installer works on RHEL with officially supported packages because this will be the usage we support once we start providing support for the new installer (and this is not a matter of preference but of support policies).

If folks want to land hacks to work around outdated RHEL/CentOS packages.

Using supported and documented way to get packages on RHEL is no hack.

I'd like to have a clearer picture around the RHEL/CentOS lifecycle plans for those outdated packages so I can understand how portable these proposed workarounds are.

For support policy see https://access.redhat.com/support/policy/updates/errata/
This is no workaround and there is no portability. Instructions work for RHEL 7 and CentOS 7 only.

@akostadinov akostadinov force-pushed the master branch 2 times, most recently from 445a483 to d74718d Compare November 27, 2018 06:29
@akostadinov
Copy link
Author

bump, anything not addressed?

@akostadinov
Copy link
Author

bump

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akostadinov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: abhinavdahiya

If they are not already assigned, you can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@akostadinov: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade dd07f8f link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akostadinov
Copy link
Author

error cannot have anything to do with pull request

@abhinavdahiya
Copy link
Contributor

closing due to inactivity. Please reopen if needed.

/close

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: Closed this PR.

Details

In response to this:

closing due to inactivity. Please reopen if needed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants