Update env for upi vsphere zone config #38241

WenXinWei · 2023-04-12T07:48:33Z

update the hardcode master/worker replicas with dynamic env for upi-conf-vsphere-zones-command.sh to unblock openshift/installer#6999

openshift-ci-robot · 2023-04-12T07:49:41Z

@WenXinWei: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-installer-master-e2e-vsphere-upi-zones	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.15-e2e-vsphere-upi-zones	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.14-e2e-vsphere-upi-zones	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.13-e2e-vsphere-upi-zones	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-master-e2e-vsphere-upi-zones	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-4.15-e2e-vsphere-upi-zones	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-4.14-e2e-vsphere-upi-zones	openshift/machine-config-operator	presubmit	Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-vsphere-upi-zones	N/A	periodic	Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-vsphere-upi-zones	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-upi-zones-p2-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-upi-zones-p2-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-e2e-vsphere-upi-zones	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2023-04-12T08:26:32Z

@WenXinWei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test app-ci-config-dry
/test boskos-config
/test boskos-config-generation
/test build-clusters
/test build01-dry
/test build02-dry
/test build03-dry
/test build04-dry
/test build05-dry
/test check-gh-automation
/test ci-operator-config
/test ci-operator-config-metadata
/test ci-operator-registry
/test ci-secret-bootstrap-config-validation
/test ci-testgrid-allow-list
/test clusterimageset-validate
/test config
/test core-valid
/test correctly-sharded-config
/test deprecate-templates
/test generated-config
/test generated-dashboards
/test hive-dry
/test jira-lifecycle-config
/test openshift-image-mirror-mappings
/test ordered-prow-config
/test owners
/test pr-reminder-config
/test prow-config
/test prow-config-filenames
/test prow-config-semantics
/test pylint
/test release-config
/test release-controller-config
/test secret-generator-config-valid
/test services-valid
/test step-registry-metadata
/test step-registry-shellcheck
/test supplemental-ci-images-mapping-files
/test sync-rover-groups
/test yamllint

The following commands are available to trigger optional jobs:

/test arm01-dry
/test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-master-build-clusters
pull-ci-openshift-release-master-ci-operator-config
pull-ci-openshift-release-master-ci-operator-registry
pull-ci-openshift-release-master-core-valid
pull-ci-openshift-release-master-correctly-sharded-config
pull-ci-openshift-release-master-deprecate-templates
pull-ci-openshift-release-master-owners
pull-ci-openshift-release-master-release-controller-config
pull-ci-openshift-release-master-step-registry-metadata
pull-ci-openshift-release-master-step-registry-shellcheck
pull-ci-openshift-release-openshift-image-mirror-mappings
pull-ci-openshift-release-yamllint

Details

In response to this:

/test e2e-vsphere-upi-zones

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WenXinWei · 2023-04-12T08:35:18Z

/pj-rehearse pull-ci-openshift-installer-master-e2e-vsphere-upi-zones

WenXinWei · 2023-04-17T02:44:56Z

/pj-rehearse pull-ci-openshift-installer-master-e2e-vsphere-upi-zones

WenXinWei · 2023-04-17T08:41:24Z

/pj-rehearse pull-ci-openshift-installer-master-e2e-vsphere-upi-zones

WenXinWei · 2023-04-19T14:26:31Z

/pj-rehearse pull-ci-openshift-installer-master-e2e-vsphere-upi-zones

WenXinWei · 2023-04-20T01:59:34Z

/pj-rehearse pull-ci-openshift-installer-master-e2e-vsphere-upi-zones

WenXinWei · 2023-04-21T07:04:30Z

@jianlinliu @jinyunma please help review the pr when you have time, thanks.

jianlinliu · 2023-04-21T07:46:25Z

What is the motive to update the logic? We are going to use the replica ENV to do some overriding?

WenXinWei · 2023-04-21T08:35:09Z

What is the motive to update the logic? We are going to use the replica ENV to do some overriding?

for the PR:openshift/installer#6999, the job 'e2e-vsphere-upi-zones' failed with :
│ local.compute_fqdns is tuple with 3 elements
│ module.ipam_compute.ip_addresses is list of string with 4 elements.

in variables.tf, the compute_count default count is 3. The number of compute_ip_address before are 4 -->["192.168.${third_octet}.7", "192.168.${third_octet}.8","192.168.${third_octet}.9", "192.168.${third_octet}.10'']. there will be conflicts. So need to changed the hard-code compute_ip_addresses to dynamic to suit the WORKER_REPLICAS (4)set in e2e-vsphere-upi-zones.

WenXinWei · 2023-04-21T08:36:15Z

/pj-rehearse pull-ci-openshift-installer-master-e2e-vsphere-upi-zones

jianlinliu · 2023-04-21T09:54:35Z

for the PR:openshift/installer#6999, the job 'e2e-vsphere-upi-zones' failed with : │ local.compute_fqdns is tuple with 3 elements │ module.ipam_compute.ip_addresses is list of string with 4 elements.

in variables.tf, the compute_count default count is 3. The number of compute_ip_address before are 4 -->["192.168.${third_octet}.7", "192.168.${third_octet}.8","192.168.${third_octet}.9", "192.168.${third_octet}.10'']. there will be conflicts. So need to changed the hard-code compute_ip_addresses to dynamic to suit the WORKER_REPLICAS (4)set in e2e-vsphere-upi-zones.

Nice catch!

jinyunma · 2023-04-21T10:41:53Z

ci-operator/step-registry/upi/conf/vsphere/zones/upi-conf-vsphere-zones-commands.sh

when $MASRER_REPLICAS > 3, the ip will overlap with worker's ip. The worker num should be based on master num.

jianlinliu · 2023-04-23T06:58:24Z

ci-operator/step-registry/upi/conf/vsphere/zones/upi-conf-vsphere-zones-commands.sh

if use if block here, pls add the leading white spaces for the following lines.

Suggest to use two if blocks to judge MASTER_REPLICAS and WORKER_REPLICAS case separately.

thanks for advice, only worker nums can be set to 0 when compact cluster scenario, so finally i add a if block for worker part.

openshift-ci-robot · 2023-04-23T09:20:07Z

[REHEARSALNOTIFIER]
@WenXinWei: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-machine-config-operator-master-e2e-vsphere-upi-zones	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-4.15-e2e-vsphere-upi-zones	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-4.14-e2e-vsphere-upi-zones	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-installer-master-e2e-vsphere-upi-zones	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.15-e2e-vsphere-upi-zones	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.14-e2e-vsphere-upi-zones	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.13-e2e-vsphere-upi-zones	openshift/installer	presubmit	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-upi-zones-p2-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-e2e-vsphere-upi-zones	N/A	periodic	Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-vsphere-upi-zones	N/A	periodic	Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-vsphere-upi-zones	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-upi-zones-p2-f14	N/A	periodic	Registry content changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

WenXinWei · 2023-04-23T09:26:03Z

/pj-rehearse pull-ci-openshift-installer-master-e2e-vsphere-upi-zones

openshift-ci · 2023-04-23T12:07:41Z

@WenXinWei: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jianlinliu · 2023-04-23T12:40:59Z

/lgtm

jianlinliu · 2023-04-23T12:41:51Z

/pj-rehearse ack

jinyunma · 2023-04-24T05:23:07Z

@jcpowermac @rvanderp3 could you help to review? thanks.

rvanderp3 · 2023-04-24T12:31:13Z

nice change, thanks for putting this together.

/approve

openshift-ci · 2023-04-24T12:39:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, rvanderp3, WenXinWei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/step-registry/upi/conf/vsphere/zones/OWNERS~~ [rvanderp3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from DennisPeriquet and stbenjam April 12, 2023 07:49

WenXinWei force-pushed the update_upi_zone branch from 23f0e88 to c564172 Compare April 17, 2023 02:40

WenXinWei force-pushed the update_upi_zone branch 2 times, most recently from ccfb96d to 3fab7f4 Compare April 17, 2023 08:38

WenXinWei force-pushed the update_upi_zone branch 14 times, most recently from 3ea44fa to 72d849b Compare April 19, 2023 14:20

WenXinWei force-pushed the update_upi_zone branch 4 times, most recently from 7c8093f to 0c721a5 Compare April 20, 2023 06:22

WenXinWei force-pushed the update_upi_zone branch from cefed97 to 9b8fcfe Compare April 21, 2023 08:02

jinyunma reviewed Apr 21, 2023

View reviewed changes

WenXinWei force-pushed the update_upi_zone branch 2 times, most recently from 72b54f6 to 56f8ba5 Compare April 23, 2023 06:50

jianlinliu reviewed Apr 23, 2023

View reviewed changes

WenXinWei force-pushed the update_upi_zone branch from 56f8ba5 to 5c5a771 Compare April 23, 2023 09:13

update env for upi zone

a2d4c88

WenXinWei force-pushed the update_upi_zone branch from 5c5a771 to a2d4c88 Compare April 23, 2023 09:18

openshift-ci bot assigned jianlinliu Apr 23, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2023

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 23, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023

openshift-ci bot merged commit 37b9ee3 into openshift:master Apr 24, 2023

ascerra pushed a commit to ascerra/release that referenced this pull request May 8, 2023

update env for upi zone (openshift#38241)

b3832d7

WenXinWei mentioned this pull request May 15, 2023

OCPBUGS-10306: [vSphere] Upi installation failed due to VMs for master and worker node creation failed openshift/installer#6999

Merged

WenXinWei mentioned this pull request Sep 25, 2023

[release-4.13] OCPBUGS-14551: [vSphere] Upi installation failed due to VMs for master and worker node creation failed openshift/installer#7229

Merged

Update env for upi vsphere zone config #38241

Update env for upi vsphere zone config #38241

Uh oh!

Conversation

WenXinWei commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 12, 2023

Uh oh!

openshift-ci bot commented Apr 12, 2023

Uh oh!

WenXinWei commented Apr 12, 2023

Uh oh!

WenXinWei commented Apr 17, 2023

Uh oh!

WenXinWei commented Apr 17, 2023

Uh oh!

WenXinWei commented Apr 19, 2023

Uh oh!

WenXinWei commented Apr 20, 2023

Uh oh!

WenXinWei commented Apr 21, 2023

Uh oh!

jianlinliu commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WenXinWei commented Apr 21, 2023

Uh oh!

WenXinWei commented Apr 21, 2023

Uh oh!

jianlinliu commented Apr 21, 2023

Uh oh!

jinyunma Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

jianlinliu Apr 23, 2023

Choose a reason for hiding this comment

Uh oh!

WenXinWei Apr 23, 2023

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 23, 2023

Uh oh!

WenXinWei commented Apr 23, 2023

Uh oh!

openshift-ci bot commented Apr 23, 2023

Uh oh!

jianlinliu commented Apr 23, 2023

Uh oh!

jianlinliu commented Apr 23, 2023

Uh oh!

jinyunma commented Apr 24, 2023

Uh oh!

rvanderp3 commented Apr 24, 2023

Uh oh!

openshift-ci bot commented Apr 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WenXinWei commented Apr 12, 2023 •

edited

Loading

jianlinliu commented Apr 21, 2023 •

edited

Loading