-
Notifications
You must be signed in to change notification settings - Fork 1.5k
SPLAT-636: Create edge compute pool to support AWS Local Zones #6931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPLAT-636: Create edge compute pool to support AWS Local Zones #6931
Conversation
This change generates the CNO manifest file `cluster-network-03-config.yml` into the cluster manifest path. The goal is to force the Cluster Network to use MTU according to the network plugin when the AWS Edge machine pool is set. Currently, there is support only for AWS Local Zones on the edge machine pool. Local Zones limit the MTU to 1300[1] to communicate with the nodes in Availability Zones (regular zones within the region). In Phase-0[2] of support of AWS Local Zones, the instructions are added in the documentation[3]. This change is covering Phase-1[4]. [1] https://docs.aws.amazon.com/local-zones/latest/ug/how-local-zones-work.html [2] https://issues.redhat.com/browse/SPLAT-635 [3] openshift/openshift-docs#55327 [4] https://issues.redhat.com/browse/SPLAT-636
Add Documentation for Phase-1[1] of installing OCP cluster in existing VPC with Local Zone Subnets. The documentation includes CloudFormation Templates to create Local Zone public subnet and route table association. [1] Enhancement Proposal: openshift/enhancements#1232
The 'edge' compute pool is created to deploy nodes in Local Zones which should not share the same pool as the regular 'worker', due the design details, use case, and availability of edge locations in AWS. This change allows the installer to accept the item 'name=edge' on the 'compute' list on install-config.yaml, when installing a cluster in existing VPC with subnetIds located in Local Zones. The design details are available in the Enhancement Proposal[1]. [1] Enhancement Proposal: openshift/enhancements#1232
Create the Machine Set when the edge compute pool is populated or added when installing a cluster in existing VPC with subnets in Local Zones. The design details are available in the Enhancement Proposal[1]. [1] Enhancement Proposal: openshift/enhancements#1232
|
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This was an item that missed branching merge cut off by 30 minutes and the teams involved were very actively engaged in landing the fix in the days prior to. Therefore i'm approving this to merge into release-4.13 after branching. |
|
/lgtm |
1 similar comment
|
/lgtm |
|
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: This pull request references SPLAT-636 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/skip |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #6371
/assign sdodson