Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #6371

/assign sdodson

mtulio added 4 commits March 3, 2023 18:00
This change generates the CNO manifest file
`cluster-network-03-config.yml` into the cluster manifest path.

The goal is to force the Cluster Network to use MTU according to the
network plugin when the AWS Edge machine pool is set. Currently,
there is support only for AWS Local Zones on the edge machine pool.
Local Zones limit the MTU to 1300[1] to communicate with the
nodes in Availability Zones (regular zones within the region).

In Phase-0[2] of support of AWS Local Zones, the instructions are added
in the documentation[3]. This change is covering Phase-1[4].

[1] https://docs.aws.amazon.com/local-zones/latest/ug/how-local-zones-work.html
[2] https://issues.redhat.com/browse/SPLAT-635
[3] openshift/openshift-docs#55327
[4] https://issues.redhat.com/browse/SPLAT-636
Add Documentation for Phase-1[1] of installing OCP cluster in existing VPC
with Local Zone Subnets. The documentation includes CloudFormation Templates
to create Local Zone public subnet and route table association.

[1] Enhancement Proposal: openshift/enhancements#1232
The 'edge' compute pool is created to deploy nodes in Local Zones
which should not share the same pool as the regular 'worker', due
the design details, use case, and availability of edge locations in AWS.

This change allows the installer to accept the item 'name=edge' on the
'compute' list on install-config.yaml, when installing a cluster in existing VPC with subnetIds located in Local Zones.

The design details are available in the Enhancement Proposal[1].

[1] Enhancement Proposal: openshift/enhancements#1232
Create the Machine Set when the edge compute pool
is populated or added when installing a cluster in
existing VPC with subnets in Local Zones.

The design details are available in the Enhancement Proposal[1].

[1] Enhancement Proposal: openshift/enhancements#1232
@sdodson sdodson changed the title [release-4.13] RFE-2782: Create edge compute pool to support AWS Local Zones RFE-2782: Create edge compute pool to support AWS Local Zones Mar 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

RFE-2782: Create edge compute pool to support AWS Local Zones

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Mar 3, 2023

This was an item that missed branching merge cut off by 30 minutes and the teams involved were very actively engaged in landing the fix in the days prior to. Therefore i'm approving this to merge into release-4.13 after branching.

@patrickdillon
Copy link
Contributor

/lgtm

1 similar comment
@mtulio
Copy link
Contributor

mtulio commented Mar 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023
@sdodson sdodson changed the title RFE-2782: Create edge compute pool to support AWS Local Zones SPLAT-636: Create edge compute pool to support AWS Local Zones Mar 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

SPLAT-636: Create edge compute pool to support AWS Local Zones

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2023

@openshift-cherrypick-robot: This pull request references SPLAT-636 which is a valid jira issue.

Details

In response to this:

This is an automated cherry-pick of #6371

/assign sdodson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 3, 2023
@sdodson
Copy link
Member

sdodson commented Mar 3, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023
@openshift-ci openshift-ci bot requested review from mtulio and patrickdillon March 3, 2023 18:09
@patrickdillon
Copy link
Contributor

/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-disruptive 59921db link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-aws-ovn-single-node 59921db link false /test e2e-aws-ovn-single-node
ci/prow/okd-scos-e2e-aws-ovn 59921db link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn 59921db link false /test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-upgrade 59921db link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-e2e-aws-ovn-upgrade 59921db link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants