Skip to content

OCPBUGS#6800: change the MTU in Local Zones deployments #55327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adellape merged 1 commit into from
Feb 9, 2023
Merged

OCPBUGS#6800: change the MTU in Local Zones deployments #55327

adellape merged 1 commit into from
Feb 9, 2023

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Jan 30, 2023 •
edited
Loading

Version(s): 4.12+
Issue: https://issues.redhat.com/browse/OCPBUGS-6800

This PR changes the default MTU on the Day-0 guide for installing a cluster in existing VPC with AWS Local Zone subnets.

The MTU of 1200 should be the maximum allowed considering 1300 (from AWS Documentation to LZ nodes communicate with nodes in regular zones [parent region]) and 100 of OVN overhead.

Link to docs preview: https://55327--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-localzone.html#installation-localzone-generate-k8s-manifestinstalling-aws-localzone

QE review:

  • QE has approved this change.

Additional information:

Required reviewers:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2023

@mtulio: This pull request references Jira Issue OCPBUGS-6800, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Version(s): 4.12

Issue: https://issues.redhat.com/browse/OCPBUGS-6800

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 30, 2023
mtulio
mtulio commented Jan 30, 2023
View reviewed changes
@mtulio mtulio marked this pull request as draft January 30, 2023 18:49
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Jan 30, 2023

Converting to draft as we need to validate the pop-up message and the impact when changing this.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 30, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://55327--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/8347

@mtulio mtulio force-pushed the OCPBUGS-6800-aws-lz-fix-mtu branch from 1539ab4 to d373e4e Compare January 30, 2023 19:05
mtulio
mtulio commented Jan 30, 2023
View reviewed changes
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023

@mtulio: This pull request references Jira Issue OCPBUGS-6800, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s): 4.12

Issue: https://issues.redhat.com/browse/OCPBUGS-6800

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Required reviewers:

  • SPLAT
  • Installer
  • Network
  • QE
  • Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023

@mtulio: This pull request references Jira Issue OCPBUGS-6800, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s): 4.12+
Issue: https://issues.redhat.com/browse/OCPBUGS-6800

This PR changes the default MTU on the Day-0 guide for installing a cluster in existing VPC with AWS Local Zone subnets.

The MTU of 1200 should be the maximum allowed considering 1300 (from AWS Documentation to LZ nodes communicate with nodes in regular zones [parent region]) and 100 of OVN overhead.

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Required reviewers:

  • SPLAT
  • Installer
  • Network
  • QE
  • Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mtulio
mtulio commented Jan 31, 2023
View reviewed changes
Copy link
Contributor Author

@mtulio mtulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the option to configure OpenShift SDN (not tested) and an "IMPORTANT" note.

mtulio
mtulio commented Jan 31, 2023
View reviewed changes
Copy link
Contributor Author

@mtulio mtulio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Jan 31, 2023 •
edited
Loading

@kalexand-rh @GroceryBoyJr As you worked on the GA document, it would be nice to have your review here. Thanks!

@mtulio
Copy link
Contributor Author

mtulio commented Jan 31, 2023

/assign @yunjiang29 @rvanderp3

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023

@mtulio: This pull request references Jira Issue OCPBUGS-6800, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s): 4.12+
Issue: https://issues.redhat.com/browse/OCPBUGS-6800

This PR changes the default MTU on the Day-0 guide for installing a cluster in existing VPC with AWS Local Zone subnets.

The MTU of 1200 should be the maximum allowed considering 1300 (from AWS Documentation to LZ nodes communicate with nodes in regular zones [parent region]) and 100 of OVN overhead.

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Required reviewers:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio
Copy link
Contributor Author

mtulio commented Jan 31, 2023

/assign @makentenza

kalexand-rh
kalexand-rh reviewed Jan 31, 2023
View reviewed changes
@yunjiang29
Copy link
Contributor

yunjiang29 commented Feb 1, 2023

/assign @zhaozhanqi

@zhaozhanqi
Copy link

zhaozhanqi commented Feb 1, 2023

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 1, 2023
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 9, 2023
@adellape adellape self-requested a review February 9, 2023 21:02
@adellape adellape merged commit b18a7bc into openshift:main Feb 9, 2023
@adellape
Copy link
Contributor

adellape commented Feb 9, 2023

/cherrypick enterprise-4.13

@adellape
Copy link
Contributor

adellape commented Feb 9, 2023

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 9, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 9, 2023

@adellape: new pull request created: #55789

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 9, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 9, 2023

@adellape: new pull request created: #55790

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adellape adellape removed their request for review February 9, 2023 21:29
@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 9, 2023
@mtulio mtulio deleted the OCPBUGS-6800-aws-lz-fix-mtu branch February 9, 2023 22:36
@mtulio mtulio mentioned this pull request Feb 9, 2023
Merged
mtulio added a commit to mtulio/installer that referenced this pull request Feb 9, 2023
@mtulio
RFE-2782/phase-1: Set MTU to CNI when edge pool is present on AWS
e8d5eb8 
This change introduce to installer generate the CNO manifest file
cluster-network-03-config.yml into the cluster manifest path.

The goal is to force the Cluster Network to use MTU according to the
network plugin when the AWS Edge machine pool is set. Currently
there is support only for AWS Local Zones on edge machine pool.
Local Zones limits the MTU for 1300[1] to communicate into the
nodes in Availability Zones (regular zones within the region).

On the Phase-0[2] of support of AWS Local Zones, the instructions is added
in the documentation[3]. This change is covering the Phase-1[4].

[1] https://docs.aws.amazon.com/local-zones/latest/ug/how-local-zones-work.html
[2] https://issues.redhat.com/browse/SPLAT-635
[3] openshift/openshift-docs#55327
[4] https://issues.redhat.com/browse/SPLAT-636
mtulio added a commit to mtulio/installer that referenced this pull request Feb 9, 2023
@mtulio
RFE-2782/phase-1: Set MTU to CNI when edge pool is present on AWS
ded90c3 
This change generates the CNO manifest file
`cluster-network-03-config.yml` into the cluster manifest path.

The goal is to force the Cluster Network to use MTU according to the
network plugin when the AWS Edge machine pool is set. Currently,
there is support only for AWS Local Zones on the edge machine pool.
Local Zones limit the MTU to 1300[1] to communicate with the
nodes in Availability Zones (regular zones within the region).

In Phase-0[2] of support of AWS Local Zones, the instructions are added
in the documentation[3]. This change is covering Phase-1[4].

[1] https://docs.aws.amazon.com/local-zones/latest/ug/how-local-zones-work.html
[2] https://issues.redhat.com/browse/SPLAT-635
[3] openshift/openshift-docs#55327
[4] https://issues.redhat.com/browse/SPLAT-636
mtulio added a commit to mtulio/installer that referenced this pull request Feb 10, 2023
@mtulio
RFE-2782/phase-1: Set MTU to CNI when edge pool is present on AWS
06dcb2d 
This change generates the CNO manifest file
`cluster-network-03-config.yml` into the cluster manifest path.

The goal is to force the Cluster Network to use MTU according to the
network plugin when the AWS Edge machine pool is set. Currently,
there is support only for AWS Local Zones on the edge machine pool.
Local Zones limit the MTU to 1300[1] to communicate with the
nodes in Availability Zones (regular zones within the region).

In Phase-0[2] of support of AWS Local Zones, the instructions are added
in the documentation[3]. This change is covering Phase-1[4].

[1] https://docs.aws.amazon.com/local-zones/latest/ug/how-local-zones-work.html
[2] https://issues.redhat.com/browse/SPLAT-635
[3] openshift/openshift-docs#55327
[4] https://issues.redhat.com/browse/SPLAT-636
mtulio added a commit to mtulio/installer that referenced this pull request Feb 27, 2023
@mtulio
RFE-2782/phase-1: Set MTU to CNI when edge pool is present on AWS
943162a 
This change generates the CNO manifest file
`cluster-network-03-config.yml` into the cluster manifest path.

The goal is to force the Cluster Network to use MTU according to the
network plugin when the AWS Edge machine pool is set. Currently,
there is support only for AWS Local Zones on the edge machine pool.
Local Zones limit the MTU to 1300[1] to communicate with the
nodes in Availability Zones (regular zones within the region).

In Phase-0[2] of support of AWS Local Zones, the instructions are added
in the documentation[3]. This change is covering Phase-1[4].

[1] https://docs.aws.amazon.com/local-zones/latest/ug/how-local-zones-work.html
[2] https://issues.redhat.com/browse/SPLAT-635
[3] openshift/openshift-docs#55327
[4] https://issues.redhat.com/browse/SPLAT-636
mtulio added a commit to mtulio/installer that referenced this pull request Feb 28, 2023
@mtulio
RFE-2782/phase-1: Set MTU to CNI when edge pool is present on AWS
79d6c37 
This change generates the CNO manifest file
`cluster-network-03-config.yml` into the cluster manifest path.

The goal is to force the Cluster Network to use MTU according to the
network plugin when the AWS Edge machine pool is set. Currently,
there is support only for AWS Local Zones on the edge machine pool.
Local Zones limit the MTU to 1300[1] to communicate with the
nodes in Availability Zones (regular zones within the region).

In Phase-0[2] of support of AWS Local Zones, the instructions are added
in the documentation[3]. This change is covering Phase-1[4].

[1] https://docs.aws.amazon.com/local-zones/latest/ug/how-local-zones-work.html
[2] https://issues.redhat.com/browse/SPLAT-635
[3] openshift/openshift-docs#55327
[4] https://issues.redhat.com/browse/SPLAT-636
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/installer that referenced this pull request Mar 3, 2023
@mtulio
RFE-2782/phase-1: Set MTU to CNI when edge pool is present on AWS
9539070 
This change generates the CNO manifest file
`cluster-network-03-config.yml` into the cluster manifest path.

The goal is to force the Cluster Network to use MTU according to the
network plugin when the AWS Edge machine pool is set. Currently,
there is support only for AWS Local Zones on the edge machine pool.
Local Zones limit the MTU to 1300[1] to communicate with the
nodes in Availability Zones (regular zones within the region).

In Phase-0[2] of support of AWS Local Zones, the instructions are added
in the documentation[3]. This change is covering Phase-1[4].

[1] https://docs.aws.amazon.com/local-zones/latest/ug/how-local-zones-work.html
[2] https://issues.redhat.com/browse/SPLAT-635
[3] openshift/openshift-docs#55327
[4] https://issues.redhat.com/browse/SPLAT-636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

+4 more reviewers

@rbbratta rbbratta rbbratta left review comments

@adellape adellape adellape left review comments

@yunjiang29 yunjiang29 yunjiang29 left review comments

@makentenza makentenza makentenza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zhaozhanqi zhaozhanqi

@knobunc knobunc

@makentenza makentenza

@rvanderp3 rvanderp3

@yunjiang29 yunjiang29

Labels

branch/enterprise-4.12 branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.