Skip to content

OSDOCS-5240: doc/fix-aws-localzones: replace jq to aws --query #6993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 22, 2023
Merged

OSDOCS-5240: doc/fix-aws-localzones: replace jq to aws --query #6993

openshift-merge-robot merged 1 commit into from
Mar 22, 2023

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Mar 20, 2023

Persisting in the installer's doc the suggestion to adapt the product documentation:

  • remove jq dependency

https://issues.redhat.com/browse/OSDOCS-5240
#6931
#6371

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Mar 20, 2023

/assign @patrickdillon @yunjiang29 @maxwelldb

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mtulio mtulio changed the title doc/fix-aws-localzones: replace jq to aws --query OSDOCS-5240: doc/fix-aws-localzones: replace jq to aws --query Mar 20, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 20, 2023 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references OSDOCS-5240 which is a valid jira issue.

Details

In response to this:

Persisting in the installer's doc the suggestion to adapt the product documentation:

  • remove jq dependency

https://issues.redhat.com/browse/OSDOCS-5240
#6931
#6371

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maxwelldb
maxwelldb reviewed Mar 20, 2023
View reviewed changes
docs/user/aws/install_existing_vpc_local-zones.md
Copy link
Contributor

@maxwelldb maxwelldb Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. It's not a necessity to nix jq from this repo, but it's helpful if the commands here are as similar to what makes it into the user docs as possible.

I will work these into openshift/openshift-docs#57427 this week.

@mtulio mtulio marked this pull request as ready for review March 20, 2023 16:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2023
@openshift-ci openshift-ci bot requested review from patrickdillon and sadasu March 20, 2023 17:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 7360f11 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-workers-rhel8 7360f11 link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-aws-ovn-fips 7360f11 link false /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-single-node 7360f11 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-proxy 7360f11 link false /test e2e-aws-ovn-proxy
ci/prow/e2e-aws-ovn-shared-vpc 7360f11 link false /test e2e-aws-ovn-shared-vpc
ci/prow/e2e-aws-ovn-imdsv2 7360f11 link false /test e2e-aws-ovn-imdsv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yunjiang29
Copy link
Contributor

yunjiang29 commented Mar 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 21, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit 32775ce into openshift:master Mar 22, 2023
@mtulio mtulio mentioned this pull request Mar 28, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sadasu sadasu Awaiting requested review from sadasu

1 more reviewer

@maxwelldb maxwelldb maxwelldb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

@maxwelldb maxwelldb

@yunjiang29 yunjiang29

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mtulio @openshift-ci-robot @yunjiang29 @patrickdillon @maxwelldb @openshift-merge-robot