linter: fix issues since revision 75173a17cf #6712
Conversation
pkg/asset/agent/image/agentimage.go
Outdated
There was a problem hiding this comment.
this would be one I'm interested in learning more about
There was a problem hiding this comment.
I'll follow up with the agent-installer team on this one. gosec always expects 0600 or less.
There was a problem hiding this comment.
Follow up on slack discussion - I tested it using 0600 and its fine, I will create a PR to change this
| switch { | ||
| case tc.expectedError != "": | ||
| assert.ErrorContains(t, err, tc.expectedError) | ||
| } else if len(tc.expectedConfig) == 0 { | ||
| case len(tc.expectedConfig) == 0: | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, tc.expectedConfig, asset.Config) | ||
| } else { | ||
| default: |
There was a problem hiding this comment.
Perhaps overly prescriptive, but I kind of like it
| mac-address: 52:54:01:aa:aa:a1` | ||
|
|
||
| // config with route but no interface is invalid | ||
| // config with route but no interface is invalid. |
There was a problem hiding this comment.
Hm... I didn't think godot would dot this kind of comment... I was curious what they meant by "top-level"
There was a problem hiding this comment.
It seems the default is declarations [1]. But what that means is based on the Golang's AST [2]. I'll play around with the settings if we start getting too many of these.
[1] https://golangci-lint.run/usage/linters/#godot
[2] tetafro/godot#22 (comment)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/skip |
|
/override ci/prow/e2e-azure-ovn ci/prow/e2e-vsphere-ovn |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn, ci/prow/e2e-vsphere-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-azure-ovn ci/prow/e2e-gcp-ovn ci/prow/e2e-vsphere-ovn |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn, ci/prow/e2e-gcp-ovn, ci/prow/e2e-vsphere-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-azure-ovn ci/prow/e2e-gcp-ovn ci/prow/e2e-vsphere-ovn ci/prow/e2e-aws-ovn |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-aws-ovn, ci/prow/e2e-azure-ovn, ci/prow/e2e-gcp-ovn, ci/prow/e2e-vsphere-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
No description provided.