OCPBUGS-2968: bootstrap: Do not needlessly podman pull #6536
Conversation
|
/retest-required |
1 similar comment
|
/retest-required |
There was a problem hiding this comment.
We probably want to still record_service_stage_success even if we don't need to pull an image.
There was a problem hiding this comment.
What about using podman image exists "$RELEASE_IMAGE"?
|
Maybe we should create a bug for this so it can be backported to previous release branches? |
celebdor
changed the title
|
@celebdor: This pull request references Jira Issue OCPBUGS-2968, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@celebdor: This pull request references Jira Issue OCPBUGS-2968, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@celebdor Are you still working on this PR? There are some reviewer comments to be addressed. |
celebdor
force-pushed
the
check-before-pull
branch
from
b73edde to
b6244ee
Compare
There was a problem hiding this comment.
nit: could be extracted before the if to remove the duplication
|
/lgtm |
|
/test ci/prow/e2e-agent-sno-ipv6 |
|
@andfasano: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
celebdor
force-pushed
the
check-before-pull
branch
from
b6244ee to
e8ce40e
Compare
|
/lgtm |
|
/override ci/prow/golint |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/golint DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When the release image is already present, the script should not try pulling. This slows down bootstrapping as well as breaking image pre-caching. Signed-off-by: Antoni Segura Puimedon <[email protected]>
celebdor
force-pushed
the
check-before-pull
branch
from
e8ce40e to
9d5e877
Compare
|
/lgtm |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-reference
|
@zaneb: This pull request references Jira Issue OCPBUGS-2968, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@bfournie: This pull request references Jira Issue OCPBUGS-2968, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@celebdor: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
@celebdor: Jira Issue OCPBUGS-2968: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-2968 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
When the release image is already present, the script should not try pulling. This slows down bootstrapping as well as breaking image pre-caching.
Signed-off-by: Antoni Segura Puimedon [email protected]