Skip to content

CORS-2340: hack: replace deprecated go-lint #6601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 16, 2022
Merged

CORS-2340: hack: replace deprecated go-lint #6601

openshift-merge-robot merged 1 commit into from
Dec 16, 2022

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Nov 18, 2022

Use golangci-lint instead, which is an aggregator of linters.

Resolves https://issues.redhat.com/browse/CORS-2340

@r4f4
Copy link
Contributor Author

r4f4 commented Nov 18, 2022

CI change: openshift/release#34150

barbacbd
barbacbd reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Talked to Rafael about edging down the number of warnings and there is a plan in place, so I am good here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 22, 2022

/hold
Needs the PR in the release repo in first.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2022
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 22, 2022

/lgtm

Talked to Rafael about edging down the number of warnings and there is a plan in place, so I am good here.

Just to expand on this, the plan is to use --new-from-rev=$master_commit (see openshift/release#34150) , so the linter should only report warnings on newly added code. I'm not hard-coding this option to hack/go-lint.sh since it can easily be passed in by the devs during local development.

@r4f4
Copy link
Contributor Author

r4f4 commented Nov 28, 2022

/test golint

@r4f4 r4f4 force-pushed the go-lint-deprecated branch from d71899a to 5fb6974 Compare November 28, 2022 23:17
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@r4f4 r4f4 force-pushed the go-lint-deprecated branch from 5fb6974 to 3a2c819 Compare November 29, 2022 15:34
@r4f4 r4f4 force-pushed the go-lint-deprecated branch from 9985b24 to 4d4c3f1 Compare December 8, 2022 20:02
@r4f4 r4f4 mentioned this pull request Dec 9, 2022
Merged
@cjschaef cjschaef mentioned this pull request Dec 13, 2022
Merged
@rna-afk rna-afk mentioned this pull request Dec 13, 2022
Merged
@r4f4 r4f4 force-pushed the go-lint-deprecated branch 2 times, most recently from 756f0a8 to 3d8e829 Compare December 13, 2022 20:31
@r4f4 r4f4 mentioned this pull request Dec 15, 2022
Merged
@patrickdillon
Copy link
Contributor

patrickdillon commented Dec 15, 2022

/approve

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@r4f4 r4f4 force-pushed the go-lint-deprecated branch from 3d8e829 to db44149 Compare December 15, 2022 14:02
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2022
@r4f4
CORS-2340: hack: replace deprecated go-lint
83d0a6a 
Use golangci-lint instead, which is an aggregator of linters.

Resolves https://issues.redhat.com/browse/CORS-2340
@r4f4 r4f4 force-pushed the go-lint-deprecated branch from db44149 to 83d0a6a Compare December 15, 2022 16:52
@r4f4 r4f4 mentioned this pull request Dec 15, 2022
Merged
@r4f4
Copy link
Contributor Author

r4f4 commented Dec 15, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2022
@patrickdillon
Copy link
Contributor

patrickdillon commented Dec 15, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@r4f4
Copy link
Contributor Author

r4f4 commented Dec 15, 2022

/override ci/prow/golint
I will fix linting issues in a follow-up PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/golint

Details

In response to this:

/override ci/prow/golint
I will fix linting issues in a follow-up PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 15, 2022

/retest-required

Remaining retests: 0 against base HEAD 9377cb3 and 2 for PR HEAD 83d0a6a in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 15, 2022

/retest-required

Remaining retests: 0 against base HEAD 5ef0adf and 1 for PR HEAD 83d0a6a in total

@r4f4
Copy link
Contributor Author

r4f4 commented Dec 16, 2022

/override ci/prow/e2e-azure-ovn
Test timeout after 4h, install succeeded.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn

Details

In response to this:

/override ci/prow/e2e-azure-ovn
Test timeout after 4h, install succeeded.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Dec 16, 2022

/override ci/prow/golint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/golint

Details

In response to this:

/override ci/prow/golint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Dec 16, 2022

/skip

@r4f4
Copy link
Contributor Author

r4f4 commented Dec 16, 2022

/override ci/prow/e2e-aws-ovn ci/prow/e2e-gcp-ovn ci/prow/e2e-vsphere-ovn ci/prow/images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-aws-ovn, ci/prow/e2e-gcp-ovn, ci/prow/e2e-vsphere-ovn, ci/prow/images

Details

In response to this:

/override ci/prow/e2e-aws-ovn ci/prow/e2e-gcp-ovn ci/prow/e2e-vsphere-ovn ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4a0d158 into openshift:master Dec 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 83d0a6a link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-openstack 83d0a6a link false /test e2e-openstack
ci/prow/okd-scos-e2e-aws-ovn 83d0a6a link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-workers-rhel8 83d0a6a link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-metal-assisted 83d0a6a link false /test e2e-metal-assisted
ci/prow/e2e-ibmcloud-ovn 83d0a6a link false /test e2e-ibmcloud-ovn
ci/prow/e2e-aws-ovn-disruptive 83d0a6a link false /test e2e-aws-ovn-disruptive
ci/prow/golint 83d0a6a link unknown /test golint
ci/prow/e2e-libvirt 83d0a6a link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4 r4f4 deleted the go-lint-deprecated branch December 16, 2022 16:03
@r4f4 r4f4 mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

1 more reviewer

@barbacbd barbacbd barbacbd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

@barbacbd barbacbd

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@r4f4 @patrickdillon @openshift-ci-robot @barbacbd @openshift-merge-robot