CORS-2386: IBMCloud: Add networkResourceGroupName #6613

cjschaef · 2022-11-22T19:02:24Z

Added a new installconfig option, networkResourceGroupName, to
specify the existing ResourceGroup where existing BYON resources
exist. This allows the use to create new cluster resources in new
ResourceGroups, or specify the existing ResourceGroup (even the
same as network) to create those resources.

Related: https://issues.redhat.com/browse/CORS-2386

cjschaef · 2022-11-22T19:04:05Z

Placing on hold as it required the MAPI PR to merge, so we can update go mod with the new changes
openshift/machine-api-provider-ibmcloud#12
Removing this TODO marker
https://github.com/openshift/installer/pull/6613/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R263-R264

/hold

cjschaef · 2022-11-23T15:32:58Z

Retesting set of failed e2e tests
/retest

cjschaef · 2022-11-30T17:57:19Z

openshift/machine-api-provider-ibmcloud#12 has merged.
Updating go mod and rebasing to remove hold.

cjschaef · 2022-12-01T21:52:56Z

Rebase complete, local testing using the MAPI changes https://amd64.ocp.releases.ci.openshift.org/releasestream/4.13.0-0.ci/release/4.13.0-0.ci-2022-11-30-231313 went well.

Ready for review.
/unhold

cjschaef · 2022-12-02T20:11:06Z

Looks like conformance instability
/retest

cjschaef · 2022-12-05T14:27:16Z

I'll see about rebasing and updating go modules again.
/hold

cjschaef · 2022-12-06T19:42:20Z

Working on rebasing go mod once again.

cjschaef · 2022-12-07T23:06:22Z

I'll rebase and rebuilt the go mod changes again.

jeffnowicki · 2023-01-05T14:51:29Z

/retest

cjschaef · 2023-01-09T14:57:26Z

Will attempt to rebuild go modules.

cjschaef · 2023-02-06T16:05:30Z

/retest

cjschaef · 2023-02-07T16:17:16Z

Looks like I need to rebase go.mod/go.sum again based off the e2e failures, will try that to see if that improves test results.

 Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging data/data/install.openshift.io_installconfigs.yaml
Automatic merge failed; fix conflicts and then commit the result.
# Error: exit status 1

cjschaef · 2023-02-07T21:28:30Z

I rebased and rebuilt go mod changes in hopes that things work properly now

Added a new installconfig option, networkResourceGroupName, to specify the existing ResourceGroup where existing BYON resources exist. This allows the use to create new cluster resources in new ResourceGroups, or specify the existing ResourceGroup (even the same as network) to create those resources. Related: https://issues.redhat.com/browse/CORS-2386

Update the go mod and vendor packages to pull in the necessary IBM Cloud MAPI changes for NetworkResourceGroupName support.

cjschaef · 2023-02-10T14:51:49Z

/retest

cjschaef · 2023-02-10T19:11:30Z

/retest

jeffnowicki · 2023-02-11T19:50:14Z

/retest

cjschaef · 2023-02-13T15:37:50Z

/retest

cjschaef · 2023-02-13T15:38:24Z

/unhold

rvanderp3

/lgtm

openshift-ci · 2023-02-13T20:50:42Z

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-sno	c057548ca188c4e814fe8527e1004b181ce0928c	link	false	`/test e2e-agent-sno`
ci/prow/e2e-agent-compact-ipv4	5e6409da10968f0e6e8ef05ea247b4ffa7d93012	link	true	`/test e2e-agent-compact-ipv4`
ci/prow/e2e-libvirt	4f9bfa41608ee1504a3f6e5065ce956cf1191a95	link	false	`/test e2e-libvirt`
ci/prow/agent-integration-tests	4f9bfa41608ee1504a3f6e5065ce956cf1191a95	link	true	`/test agent-integration-tests`
ci/prow/e2e-metal-ipi-sdn-virtualmedia	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-metal-ipi-sdn-virtualmedia`
ci/prow/e2e-gcp-ovn-shared-vpc	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-gcp-ovn-shared-vpc`
ci/prow/e2e-aws-ovn-fips	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-aws-ovn-fips`
ci/prow/e2e-openstack-proxy	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-openstack-proxy`
ci/prow/e2e-openstack-sdn-parallel	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-openstack-sdn-parallel`
ci/prow/e2e-aws-ovn-shared-vpc	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-aws-ovn-shared-vpc`
ci/prow/e2e-aws-ovn-single-node	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-metal-ipi-ovn-dualstack	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-metal-ipi-ovn-dualstack`
ci/prow/e2e-aws-ovn-imdsv2	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-aws-ovn-imdsv2`
ci/prow/e2e-aws-ovn-disruptive	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-aws-ovn-disruptive`
ci/prow/e2e-alibaba	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-alibaba`
ci/prow/e2e-gcp-ovn	5c06cef0b5e2c7900485fa322e979c509b269e68	link	true	`/test e2e-gcp-ovn`
ci/prow/e2e-gcp-secureboot	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-gcp-secureboot`
ci/prow/e2e-azurestack	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-azurestack`
ci/prow/e2e-metal-ipi-sdn	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-metal-ipi-sdn`
ci/prow/e2e-metal-assisted	5c06cef0b5e2c7900485fa322e979c509b269e68	link	false	`/test e2e-metal-assisted`
ci/prow/e2e-metal-ipi-ovn-ipv6	5c06cef0b5e2c7900485fa322e979c509b269e68	link	true	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-ibmcloud-ovn	`b406fbd`	link	false	`/test e2e-ibmcloud-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cjschaef · 2023-02-14T16:27:53Z

e2e-ibmcloud-ovn test failure

 level=warning msg=Failed to delete resource group ci-op-gk1gk7vl-52953-4dt5v: Resource groups with active or pending reclamation instances can't be deleted. Use the CLI commands "ibmcloud resource service-instances --type all" and "ibmcloud resource reclamations" to check for remaining instances, then delete the instances and try again.
level=warning msg=Failed to delete resource group ci-op-gk1gk7vl-52953-4dt5v: Resource groups with active or pending reclamation instances can't be deleted. Use the CLI commands "ibmcloud resource service-instances --type all" and "ibmcloud resource reclamations" to check for remaining instances, then delete the instances and try again.
{"component":"entrypoint","file":"k8s.io/test-infra/prow/entrypoint/run.go:254","func":"k8s.io/test-infra/prow/entrypoint.gracefullyTerminate","level":"error","msg":"Process did not exit before 10m0s grace period","severity":"error","time":"2023-02-13T20:49:44Z"}
{"component":"entrypoint","error":"os: process already finished","file":"k8s.io/test-infra/prow/entrypoint/run.go:256","func":"k8s.io/test-infra/prow/entrypoint.gracefullyTerminate","level":"error","msg":"Could not kill process after grace period","severity":"error","time":"2023-02-13T20:49:44Z"}
{"component":"entrypoint","error":"process timed out","file":"k8s.io/test-infra/prow/entrypoint/run.go:79","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2023-02-13T20:49:44Z"}
error: failed to execute wrapped command: exit status 127 
INFO[2023-02-13T20:49:48Z] Step e2e-ibmcloud-ovn-ipi-deprovision-deprovision failed after 1h10m20s. 
INFO[2023-02-13T20:49:48Z] Step phase post failed after 1h20m21s.

This appears to be the same known bug in IBM Cloud, same issue as other PR's (and CI) are suffering
#6845 (comment)

patrickdillon · 2023-02-15T19:01:02Z

/approve

openshift-ci · 2023-02-15T19:04:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2022

openshift-ci bot requested review from AnnaZivkovic and rvanderp3 November 22, 2022 19:05

cjschaef force-pushed the cors-2386 branch from 7d81fea to c057548 Compare November 22, 2022 20:53

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022

cjschaef force-pushed the cors-2386 branch from c057548 to 6987d35 Compare December 1, 2022 21:13

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022

cjschaef force-pushed the cors-2386 branch from 6987d35 to 657b706 Compare December 5, 2022 21:03

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2022

cjschaef force-pushed the cors-2386 branch from 657b706 to 352ccb4 Compare December 6, 2022 16:40

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2022

cjschaef force-pushed the cors-2386 branch from 352ccb4 to e37620e Compare December 6, 2022 19:55

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2022

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2022

cjschaef force-pushed the cors-2386 branch from e37620e to 8b97a30 Compare December 8, 2022 17:08

openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 8, 2022

cjschaef force-pushed the cors-2386 branch from 8b97a30 to 946fde0 Compare December 12, 2022 15:32

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2022

cjschaef force-pushed the cors-2386 branch from d7632bc to 4f9bfa4 Compare January 4, 2023 18:11

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2023

cjschaef force-pushed the cors-2386 branch from 4f9bfa4 to 7272c5b Compare January 30, 2023 16:23

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2023

cjschaef force-pushed the cors-2386 branch from 7272c5b to 5c06cef Compare February 7, 2023 21:27

cjschaef added 2 commits February 9, 2023 11:34

Update machine-api-provider-ibmcloud packages

b406fbd

Update the go mod and vendor packages to pull in the necessary IBM Cloud MAPI changes for NetworkResourceGroupName support.

cjschaef force-pushed the cors-2386 branch from 5c06cef to b406fbd Compare February 9, 2023 17:42

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2023

rvanderp3 reviewed Feb 13, 2023

View reviewed changes

openshift-ci bot assigned rvanderp3 Feb 13, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023

openshift-merge-robot merged commit c0bf49c into openshift:master Feb 16, 2023

cjschaef deleted the cors-2386 branch February 16, 2023 15:39

MayXuQQ mentioned this pull request Feb 17, 2023

CORS-2557 [ibmcloud] networkResourceGroupName in install-config.yaml openshift/release#36512

Merged

CORS-2386: IBMCloud: Add networkResourceGroupName #6613

CORS-2386: IBMCloud: Add networkResourceGroupName #6613

Uh oh!

Conversation

cjschaef commented Nov 22, 2022

Uh oh!

cjschaef commented Nov 22, 2022

Uh oh!

cjschaef commented Nov 23, 2022

Uh oh!

cjschaef commented Nov 30, 2022

Uh oh!

cjschaef commented Dec 1, 2022

Uh oh!

cjschaef commented Dec 2, 2022

Uh oh!

cjschaef commented Dec 5, 2022

Uh oh!

cjschaef commented Dec 6, 2022

Uh oh!

cjschaef commented Dec 7, 2022

Uh oh!

jeffnowicki commented Jan 5, 2023

Uh oh!

cjschaef commented Jan 9, 2023

Uh oh!

cjschaef commented Feb 6, 2023

Uh oh!

cjschaef commented Feb 7, 2023

Uh oh!

cjschaef commented Feb 7, 2023

Uh oh!

cjschaef commented Feb 10, 2023

Uh oh!

cjschaef commented Feb 10, 2023

Uh oh!

jeffnowicki commented Feb 11, 2023

Uh oh!

cjschaef commented Feb 13, 2023

Uh oh!

cjschaef commented Feb 13, 2023

Uh oh!

rvanderp3 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 13, 2023

Uh oh!

cjschaef commented Feb 14, 2023

Uh oh!

patrickdillon commented Feb 15, 2023

Uh oh!

openshift-ci bot commented Feb 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants