CORS-2557 [ibmcloud] networkResourceGroupName in install-config.yaml #36512

MayXuQQ · 2023-02-17T17:23:38Z

CORS-2557 CI Integration: [ibmcloud] Add support to validate and utilize a networkResourceGroupName install-config.yaml option and configure that value in Infrastructure's PlatformStatus for IBM Cloud
Prow CI ibmcloud-ipi-private all failed after [openshift/installer#6613: CORS-2386: IBMCloud: Add networkResourceGroupName](openshift/installer#6613)
https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/logs/periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7/1626441733703208960

level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: platform.ibmcloud.networkResourceGroupName: Invalid value: "": networkResourceGroupName cannot be empty when providing a vpcName: ci-op-433mwgm2-eef7e-vpc

openshift-ci-robot · 2023-02-17T17:24:28Z

@MayXuQQ: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-ibmcloud	N/A	periodic	Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-ibmcloud	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

MayXuQQ · 2023-02-17T17:55:39Z

/pj-rehearse

MayXuQQ · 2023-02-20T02:19:50Z

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-ibmcloud
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7

MayXuQQ · 2023-02-20T03:16:22Z

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7

MayXuQQ · 2023-02-20T03:52:02Z

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7

MayXuQQ · 2023-02-20T03:56:09Z

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7

MayXuQQ · 2023-02-20T10:16:34Z

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-ibmcloud

MayXuQQ · 2023-02-20T14:19:26Z

/retest

MayXuQQ · 2023-02-20T14:22:55Z

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-ibmcloud

MayXuQQ · 2023-02-20T14:23:10Z

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7

MayXuQQ · 2023-02-20T17:15:07Z

/retest

MayXuQQ · 2023-02-20T17:21:57Z

/retest

MayXuQQ · 2023-02-20T17:24:04Z

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-ibmcloud

MayXuQQ · 2023-02-20T17:31:49Z

@cjschaef Could you help look at the changes, thanks a lot.

MayXuQQ · 2023-02-21T02:27:08Z

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-ibmcloud

MayXuQQ · 2023-02-21T02:37:08Z

@jianlinliu thanks

jianlinliu · 2023-02-21T04:48:35Z

ci-operator/step-registry/ibmcloud/deprovision/vpc/ibmcloud-deprovision-vpc-commands.sh

 delete_vpc "${vpc_name}"

+echo "DEBUG" "Removing the resource reclamations ..."
+set +o errexit
+${IBMCLOUD_CLI} resource reclamations |  awk '(NR>4) {print $1}' | xargs -n1 ibmcloud resource reclamation-delete -f


This commands will be always executed, even the resources are not created by this install workflow? I think this command is out of scope.

MayXuQQ · 2023-02-21T07:01:43Z

step installer-rehearse-ibmcloud-ipi-deprovision-deprovision failed is caused by OCPBUGS-7511

jianlinliu · 2023-02-21T07:11:00Z

ci-operator/step-registry/ibmcloud/deprovision/vpc/ibmcloud-deprovision-vpc-commands.sh

+echo "DEBUG" "Removing the resource reclamations ..."
+hasReclamations=$("${IBMCLOUD_CLI}" resource reclamations |  awk '(NR==4) {print $1}')
+if [ "${hasReclamations}" != "No" ]; then
+  ${IBMCLOUD_CLI} resource reclamations |  awk '(NR>4) {print $1}' | xargs -n1 ibmcloud resource reclamation-delete -f


My point is not deleting the reclamations resources irrelevant with the installed cluster, or even we can keep the issue remaining, but run the commands locally.

the reclamations will block cleanup the resource group, then the step will failed.

Let me confirm, will the command will delete all the reclamations, even not be created from this cluster install, right?

will delete the reclamations under the resource group (the vpc created under this group)

If that, I think you do not need the line to check:

hasReclamations=$("${IBMCLOUD_CLI}" resource reclamations | awk '(NR==4) {print $1}')

And I think the removal of reclamations should happen prior to delete_vpc.

Let us finish the discussion of adding how many reclamation-delete commands here, I am okay with your present code. Now the only comment is #36512 (comment), we do not need the checking line of hasReclamations=$("${IBMCLOUD_CLI}" resource reclamations | awk '(NR==4) {print $1}') .

when no reclamations, the reclamation-delete will caused error.
$ ic resource reclamations | awk '(NR==4) {print $1}'
No
$ ic resource reclamations | awk '(NR==4) {print $1}'| xargs -n1 ibmcloud resource reclamation-delete -f
Submitting request to delete resource reclamation No under account fdc2e14cf8bc4d53a67f972dc2e2c861 as ServiceId-dff277a9-b608-410a-ad24-c544e59e3778...
FAILED
Resource reclamation 'No' was not found.

Can you show me an example output when reclamations are existing?

ic resource reclamations | awk '(NR==4) {print $1}'| xargs -n1 ibmcloud resource reclamation-delete -f

Do you mean only the resources shown on 4th line will be deleted?
If there are multiple lines for reclamations resources, how to deal with?

To easy reading for the code, I think it should be:

echo "DEBUG" "Removing the resource reclamations ..." if [[ $(ibmcloud resource reclamations -q) == "No reclamation found" ]]; then echo "No reclamation found" else ${IBMCLOUD_CLI} resource reclamations -q | awk '{print $1}' | xargs -n1 ibmcloud resource reclamation-delete -f fi

MayXuQQ · 2023-02-21T07:15:48Z

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-ibmcloud

MayXuQQ · 2023-02-21T10:18:07Z

/auto-cc

MayXuQQ · 2023-02-21T11:22:36Z

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7

MayXuQQ · 2023-02-21T14:53:11Z

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-ibmcloud

MayXuQQ · 2023-02-22T02:00:37Z

@jianlinliu how about merging the PR, then check periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-ibmcloud-ipi-private-fips-p2-f7 whether has regression in e2e test?

jianlinliu · 2023-02-22T02:09:51Z

ci-operator/step-registry/ibmcloud/deprovision/vpc/ibmcloud-deprovision-vpc-commands.sh

+if [[ $("${IBMCLOUD_CLI}" resource reclamations -q) == "No reclamation found" ]]; then
+  echo "No reclamation found"
+else
+  ${IBMCLOUD_CLI} resource reclamations -q |  awk '(NR>1) {print $1}' | xargs -n1 ibmcloud resource reclamation-delete -f


When already added -q option, still need (NR>1) in awk ?

Can you show me an example output when reclamations are existing?

reclamation-delete succeed
the first row is "ID" ( ${IBMCLOUD_CLI} resource reclamations|awk '(NR>3) {print $1}') so got is

Submitting request to delete resource reclamation ID under account fdc2e14cf8bc4d53a67f972dc2e2c861 as ServiceId-dff277a9-b608-410a-ad24-c544e59e3778...
FAILED

jianlinliu · 2023-02-22T02:48:00Z

/lgtm

openshift-ci · 2023-02-22T02:48:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, MayXuQQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/step-registry/ibmcloud/OWNERS~~ [MayXuQQ,jianlinliu]
~~ci-operator/step-registry/ipi/conf/ibmcloud/provisionednetwork/OWNERS~~ [MayXuQQ,jianlinliu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jianlinliu · 2023-02-22T02:48:30Z

/pj-rehearse ack

openshift-ci bot requested review from dgoodwin and xueqzhan February 17, 2023 17:24

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023

MayXuQQ force-pushed the ibm-CORS-2557 branch from 80e447b to 98045a3 Compare February 20, 2023 17:13

jianlinliu reviewed Feb 21, 2023

View reviewed changes

MayXuQQ force-pushed the ibm-CORS-2557 branch from b4b9300 to b19b56c Compare February 21, 2023 07:01

MayXuQQ force-pushed the ibm-CORS-2557 branch from b19b56c to 1e3e94e Compare February 21, 2023 07:09

jianlinliu reviewed Feb 21, 2023

View reviewed changes

openshift-ci bot requested review from DennisPeriquet and jianlinliu February 21, 2023 10:18

MayXuQQ force-pushed the ibm-CORS-2557 branch 2 times, most recently from 9261f75 to 2c839fe Compare February 21, 2023 14:42

CORS-2557 [ibmcloud] networkResourceGroupName in install-config.yaml

2c839fe

jianlinliu reviewed Feb 22, 2023

View reviewed changes

openshift-ci bot assigned jianlinliu Feb 22, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 22, 2023

openshift-merge-robot merged commit 669d65c into openshift:master Feb 22, 2023

CORS-2557 [ibmcloud] networkResourceGroupName in install-config.yaml #36512

CORS-2557 [ibmcloud] networkResourceGroupName in install-config.yaml #36512

Uh oh!

Conversation

MayXuQQ commented Feb 17, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 17, 2023

Uh oh!

MayXuQQ commented Feb 17, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 20, 2023

Uh oh!

MayXuQQ commented Feb 21, 2023

Uh oh!

MayXuQQ commented Feb 21, 2023

Uh oh!

jianlinliu Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MayXuQQ commented Feb 21, 2023

Uh oh!

jianlinliu Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jianlinliu Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jianlinliu Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MayXuQQ commented Feb 21, 2023

Uh oh!

MayXuQQ commented Feb 21, 2023

Uh oh!

MayXuQQ commented Feb 21, 2023

Uh oh!

MayXuQQ commented Feb 21, 2023

Uh oh!

MayXuQQ commented Feb 22, 2023

MayXuQQ commented Feb 17, 2023 •

edited by openshift-ci bot

Loading

jianlinliu Feb 21, 2023 •

edited

Loading

jianlinliu Feb 21, 2023 •

edited

Loading

jianlinliu Feb 21, 2023 •

edited

Loading

jianlinliu Feb 21, 2023 •

edited

Loading