Skip to content

CORS-2387: IBMCloud: Add NetworkResourceGroup #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 30, 2022
Merged

CORS-2387: IBMCloud: Add NetworkResourceGroup #12

openshift-merge-robot merged 1 commit into from
Nov 30, 2022

Conversation

@cjschaef
Copy link
Member

@cjschaef cjschaef commented Nov 22, 2022

Add support for a NetworkResourceGroup in the MachineProviderSpec, and the logic for performing lookups during a machine creation for IBM Cloud.

Related: https://issues.redhat.com/browse/CORS-2387

@openshift-ci openshift-ci bot requested review from elmiko and lobziik November 22, 2022 17:18
@cjschaef cjschaef mentioned this pull request Nov 22, 2022
Merged
@cjschaef
Copy link
Member Author

cjschaef commented Nov 22, 2022

/retest

lobziik
lobziik approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@lobziik lobziik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Since these changes are backward compatible think it's ok to go I think.

Only one thing, @cjschaef is it possible to update the linked JIRA card with some detailed description, since the commit message references it?

@lobziik
Copy link
Contributor

lobziik commented Nov 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
JoelSpeed
JoelSpeed reviewed Nov 28, 2022
View reviewed changes
pkg/apis/ibmcloudprovider/v1/ibmcloudproviderconfig_types.go Outdated
Comment on lines 68 to 73
// NetworkResourceGroup is Resource Group of the VPC. This may be the same as ResourceGroup if the
// machines are created in the same Resource Group as the network resources.
// (optional)
Copy link
Contributor

@JoelSpeed JoelSpeed Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when it's omitted, you should explain that within this godoc

Copy link
Member Author

@cjschaef cjschaef Nov 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can add details, that this value is required if you are using BYON resources, failing if a VPCName is provided and NRG is not. on the expectations of NRG in relation to RG and VPCName (existing BYON resources).

Copy link
Member Author

@cjschaef cjschaef Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was thinking of how this was related to the installer's install-config.yaml. In the PlatformStatus, things are slightly different, as far as expectations. I will update though.

Copy link
Member Author

@cjschaef cjschaef Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, hopefully the update I added is useful

elmiko
elmiko reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm aside from Joel's comment

@cjschaef
CORS-2387: IBMCloud: Add NetworkResourceGroup
c09540f 
Add support for a NetworkResourceGroup in the MachineProviderSpec,
and the logic for performing lookups during a machine creation
for IBM Cloud.

Related: https://issues.redhat.com/browse/CORS-2387
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2022
elmiko
elmiko reviewed Nov 29, 2022
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

will leave it for Joel to add the approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2022
@cjschaef
Copy link
Member Author

cjschaef commented Nov 29, 2022

e2e-ibmcloud failure appears to be an issue with the RHCOS image (checksum)

 level=info msg=Obtaining RHCOS image file from 'https://rhcos.mirror.openshift.com/art/storage/releases/rhcos-4.12/412.86.202209302317-0/x86_64/rhcos-412.86.202209302317-0-ibmcloud.x86_64.qcow2.gz?sha256=c96eeeb364f0b36d254fbb04378ed593f056fd69e57a1c7f152fb778e3a63696'
level=fatal msg=failed to fetch Terraform Variables: failed to generate asset "Terraform Variables": failed to get ibmcloud Terraform variables: failed to use cached ibmcloud image: gzip: invalid checksum
Setup phase finished, prepare env for next steps

Hopefully just a flake with that image/download/checksum.
/retest

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Nov 30, 2022

/approve

Looks good

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 30, 2022

/retest-required

Remaining retests: 0 against base HEAD bc112f3 and 2 for PR HEAD c09540f in total

@cjschaef
Copy link
Member Author

cjschaef commented Nov 30, 2022

e2e-ibmcloud was a Conformance failure

Suite run returned error: failed because an invariant was violated, 1255 pass, 1796 skip (48m25s)
error: failed because an invariant was violated, 1255 pass, 1796 skip (48m25s)

Monitoring until it does pass.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2022

@cjschaef: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud c09540f link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit dc53423 into openshift:main Nov 30, 2022
@cjschaef cjschaef deleted the cors-2387 branch November 30, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

+2 more reviewers

@elmiko elmiko elmiko left review comments

@lobziik lobziik lobziik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@lobziik lobziik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cjschaef @lobziik @JoelSpeed @openshift-ci-robot @elmiko @openshift-merge-robot