Add OpenStack team as reviewers #618
Conversation
As the work progresses and the familiarity with the code base grows, it would be ideal for the OpenStack team to join the reviewers team and help with specific and more focused reviews. Specifically, the team is interested in reviewing OpenStack related patches (like openshift#511) in order to ease the workload from the rest of the team. The OpenStack team won't be reviewing patches outside their area of competence.
openshift-ci-robot
added
the
size/XS
|
I would very much appreciate this. I've been operating under a similar arrangement with openshift-ansible for over a year and everyone seemed to be happy about that. It reduced the core reviewers' load and the OpenStack integration was able to catch up at full speed. Whenever we had any doubts about changing something we weren't intimately familiar with, we would ask the for guidance anyway. |
|
/lgtm Maybe we can do a better job separating the platform-specific stuff, but for now I'm fine growing the approver pool. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This reverts commit c1aa022, openshift#618. We've made a lot of progress separating out the per-platform components since that went in, so take another run at formally separating approval for per-platform and core changes.
5 participants
As the work progresses and the familiarity with the code base grows, it
would be ideal for the OpenStack team to join the reviewers team and
help with specific and more focused reviews.
Specifically, the team is interested in reviewing OpenStack related
patches (like #588 ) in order to ease the workload from the rest of the
team.
The OpenStack team won't be reviewing patches outside their area of
competence.
@hardys @tomassedovic @russellb FYI