dev-dependencies: Just use yum on Fedora too
#511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what I do. `dnf` no longer complains if invoked as `yum`; there's no point to having two separate sets of instructions. Also use `systemctl enable --now` for further brevity.
cgwalters
force-pushed
the
yum-on-fedora
branch
from
afe0a81 to
e34a20d
Compare
Member
|
Will RHEL and other hold-outs eventually drop |
Member
Author
I can't speak for "eventually" here but...I just don't think it's worth us maintaining two instructions today. The "CentOS" instructions work on Fedora and I think that's very unlikely to change. |
Member
|
/lgtm |
openshift-ci-robot
added
the
size/S
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
flaper87
added a commit
to flaper87/installer
that referenced
this pull request
Nov 6, 2018
As the work progresses and the familiarity with the code base grows, it would be ideal for the OpenStack team to join the reviewers team and help with specific and more focused reviews. Specifically, the team is interested in reviewing OpenStack related patches (like openshift#511) in order to ease the workload from the rest of the team. The OpenStack team won't be reviewing patches outside their area of competence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I do.
dnfno longer complains if invoked asyum;there's no point to having two separate sets of instructions.