Allow openstack-approvers LGTM

[tomassedovic]

Commit c1aa022 allowed openstack-approvers to approve the commits, but
not merge them (via /lgtm). This is an oversight fixed by adding the
group to reviewers in addition to approvers.

[tomassedovic]

/cc @flaper87 and @wking I think this was an oversight of #618, please correct me if I'm wrong.

[flaper87]

oh, mmh! I think I missed that part. Thanks for this patch!

[crawford]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [crawford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wking]

I think reviewers just feeds into Prow's reviewer suggestions. /lgtm is just gated by org membership (e.g. see me approving a Hive PR here). An approvers entry should be all you need to /approve (separate from /lgtming). So I currently don't see why this would be required, but I don't have a problem with landing it either ;).

[wking]

/hold

[wking]

Actually, a better example would be any of the current maintainers approving anything with /lgtm (which we do a lot ;). Currently none of the common approvers are in reviewers. Who tried to /lgtm and couldn't?

[tomassedovic]

Right, good point. The person trying and failing to /lgtm was myself here:

#588 (comment)

You've already participated in that thread and it looks like the underlying issue is elsewhere -- the openstack team (https://github.com/orgs/openshift/teams/team-openstack-cloud-provider/repositories) not being associated with this repo.

I'll close the PR for now. We can reopen it if it turns out to be useful as well.