Skip to content

Revendor with golang 1.18 #6077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Aug 13, 2022
Merged

Revendor with golang 1.18 #6077

openshift-merge-robot merged 2 commits into from
Aug 13, 2022

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Jul 4, 2022

Golang >= 1.18 is needed to use newer Azure APIs.

@openshift-ci openshift-ci bot requested review from barbacbd and kirankt July 4, 2022 14:28
barbacbd
barbacbd reviewed Jul 5, 2022
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go.sum file appears to have a lot of removals with this change to go 1.18. Are any of these going to break what is currently expected to execute?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2022
@r4f4
Copy link
Contributor Author

r4f4 commented Jul 7, 2022

Depends on #6085

@r4f4
Copy link
Contributor Author

r4f4 commented Jul 7, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2022
@r4f4
Copy link
Contributor Author

r4f4 commented Jul 22, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@r4f4
Copy link
Contributor Author

r4f4 commented Jul 22, 2022

/uncc @kirankt

@openshift-ci openshift-ci bot removed the request for review from kirankt July 22, 2022 16:50
@sadasu
Copy link
Contributor

sadasu commented Jul 25, 2022

/retest

@r4f4
Copy link
Contributor Author

r4f4 commented Jul 25, 2022

The UPI images haven't been updated to use golang-1.18 yet. See #6163

@barbacbd barbacbd mentioned this pull request Jul 27, 2022
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2022
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 1, 2022

This LGTM. Just needs a rebase

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2022
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 5, 2022

/retest

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 5, 2022

/retest-required

Remaining retests: 2 against base HEAD 6d25b78 and 8 for PR HEAD 1647e35 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 5, 2022

/retest-required

Remaining retests: 1 against base HEAD 6d25b78 and 7 for PR HEAD 1647e35 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 5, 2022

/retest-required

Remaining retests: 0 against base HEAD 6d25b78 and 6 for PR HEAD 1647e35 in total

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 5, 2022

/skip

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 5, 2022

/retest-required

Remaining retests: 2 against base HEAD d4eebc6 and 5 for PR HEAD 1647e35 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 5, 2022

/retest-required

Remaining retests: 1 against base HEAD d4eebc6 and 4 for PR HEAD 1647e35 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 5, 2022

/retest-required

Remaining retests: 0 against base HEAD d4eebc6 and 3 for PR HEAD 1647e35 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 6, 2022

/retest-required

Remaining retests: 2 against base HEAD 3f27a2e and 2 for PR HEAD 1647e35 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 6, 2022

/retest-required

Remaining retests: 1 against base HEAD 3f27a2e and 1 for PR HEAD 1647e35 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 6, 2022

/retest-required

Remaining retests: 0 against base HEAD 3f27a2e and 0 for PR HEAD 1647e35 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 6, 2022

/hold

Revision 1647e35 was retested 9 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2022
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 8, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022 •
edited
Loading

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 1647e35 link false /test e2e-openstack
ci/prow/e2e-metal-assisted 1647e35 link false /test e2e-metal-assisted
ci/prow/e2e-ovirt 1647e35 link false /test e2e-ovirt
ci/prow/okd-e2e-aws 1647e35 link false /test okd-e2e-aws
ci/prow/e2e-libvirt 1647e35 link false /test e2e-libvirt
ci/prow/e2e-metal-ipi 1647e35 link false /test e2e-metal-ipi
ci/prow/e2e-ibmcloud 1647e35 link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor Author

r4f4 commented Aug 12, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 12, 2022

/retest-required

Remaining retests: 2 against base HEAD 977b2bb and 8 for PR HEAD 1647e35 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 12, 2022

/retest-required

Remaining retests: 1 against base HEAD 977b2bb and 7 for PR HEAD 1647e35 in total

@r4f4
Copy link
Contributor Author

r4f4 commented Aug 13, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 6e8c9f9 into openshift:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@barbacbd barbacbd barbacbd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@r4f4 @sadasu @patrickdillon @openshift-ci-robot @barbacbd @openshift-merge-robot