Skip to content

Updating ose-baremetal-installer images to be consistent with ART #6085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 22, 2022
Merged

Updating ose-baremetal-installer images to be consistent with ART #6085

openshift-merge-robot merged 1 commit into from
Jul 22, 2022

Conversation

@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jul 6, 2022 •
edited
Loading

Updating ose-baremetal-installer images to be consistent with ART
TLDR:
Component owners, please ensure that this PR merges as it impacts the fidelity
of your CI signal. Patch-manager / leads, this PR is a no-op from a product
perspective -- feel free to manually apply any labels (e.g. bugzilla/valid-bug) to help the
PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is
to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test
to remove this tag and help the PR to merge.

Detail:
This repository is out of sync with the downstream product builds for this component.
One or more images differ from those being used by ART to create product builds. This
should be addressed to ensure that the component's CI testing is accurately
reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment
request: ose-baremetal-installer.yml.

The vast majority of these PRs are opened because a different Golang version is being
used to build the downstream component. ART compiles most components with the version
of Golang being used by the control plane for a given OpenShift release. Exceptions
to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift
architecture team and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team: @release-artists
    in #aos-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. Downstream builds
    are already being built with these changes. Merging this PR only improves the fidelity
    of our CI.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

@openshift-bot openshift-bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jul 6, 2022
@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.12-ose-baremetal-installer branch from a666e46 to 15dd10c Compare July 6, 2022 06:39
@openshift-ci openshift-ci bot requested review from barbacbd and celebdor July 6, 2022 06:41
@r4f4 r4f4 mentioned this pull request Jul 7, 2022
Merged
@patrickdillon
Copy link
Contributor

patrickdillon commented Jul 8, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2022
@r4f4
Copy link
Contributor

r4f4 commented Jul 12, 2022

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 12, 2022

/retest-required

Remaining retests: 2 against base HEAD 09e92dc and 8 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 12, 2022

/retest-required

Remaining retests: 1 against base HEAD 09e92dc and 7 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 12, 2022

/retest-required

Remaining retests: 0 against base HEAD 09e92dc and 6 for PR HEAD 15dd10c in total

@r4f4
Copy link
Contributor

r4f4 commented Jul 13, 2022

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 13, 2022

/retest-required

Remaining retests: 2 against base HEAD 9256b2e and 5 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 13, 2022

/retest-required

Remaining retests: 1 against base HEAD 9256b2e and 4 for PR HEAD 15dd10c in total

@patrickdillon
Copy link
Contributor

patrickdillon commented Jul 13, 2022

/skip

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 13, 2022

/retest-required

Remaining retests: 0 against base HEAD 9256b2e and 3 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 14, 2022

/retest-required

Remaining retests: 2 against base HEAD 13e49f2 and 2 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 14, 2022

/retest-required

Remaining retests: 2 against base HEAD eb1ba75 and 1 for PR HEAD 15dd10c in total

@r4f4
Copy link
Contributor

r4f4 commented Jul 16, 2022

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 16, 2022

/retest-required

Remaining retests: 2 against base HEAD 3a943ba and 0 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 16, 2022

/hold

Revision 15dd10c was retested 9 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2022
@r4f4
Copy link
Contributor

r4f4 commented Jul 17, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2022

/retest-required

Remaining retests: 2 against base HEAD 3a943ba and 8 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 18, 2022

/retest-required

Remaining retests: 1 against base HEAD 3a943ba and 7 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 18, 2022

/retest-required

Remaining retests: 0 against base HEAD 3a943ba and 6 for PR HEAD 15dd10c in total

@elfosardo
Copy link
Contributor

elfosardo commented Jul 18, 2022

/retest

@patrickdillon
Copy link
Contributor

patrickdillon commented Jul 18, 2022

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2022

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 18, 2022

/retest-required

Remaining retests: 2 against base HEAD f46ac2f and 5 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 19, 2022

/retest-required

Remaining retests: 1 against base HEAD f46ac2f and 4 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 19, 2022

/retest-required

Remaining retests: 2 against base HEAD df9dc0a and 3 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 19, 2022

/retest-required

Remaining retests: 1 against base HEAD df9dc0a and 2 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 19, 2022

/retest-required

Remaining retests: 0 against base HEAD df9dc0a and 1 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 19, 2022

/retest-required

Remaining retests: 2 against base HEAD 694e52e and 0 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 19, 2022

/hold

Revision 15dd10c was retested 9 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2022
@r4f4
Copy link
Contributor

r4f4 commented Jul 21, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 21, 2022

/retest-required

Remaining retests: 2 against base HEAD 0e1e261 and 8 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 21, 2022

/retest-required

Remaining retests: 1 against base HEAD 0e1e261 and 7 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 22, 2022

/retest-required

Remaining retests: 2 against base HEAD 85cdfd5 and 6 for PR HEAD 15dd10c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 22, 2022

/retest-required

Remaining retests: 2 against base HEAD 37ae964 and 5 for PR HEAD 15dd10c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2022 •
edited
Loading

@openshift-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws 15dd10c link false /test okd-e2e-aws
ci/prow/e2e-metal-ipi-ovn-dualstack 15dd10c link false /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

patrickdillon commented Jul 22, 2022

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2022

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 22, 2022

/retest-required

Remaining retests: 1 against base HEAD 37ae964 and 4 for PR HEAD 15dd10c in total

@openshift-merge-robot openshift-merge-robot merged commit e1ebf7c into openshift:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barbacbd barbacbd Awaiting requested review from barbacbd

@celebdor celebdor Awaiting requested review from celebdor

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-bot @patrickdillon @r4f4 @openshift-ci-robot @elfosardo @openshift-merge-robot