OCPBUGS-4541: Azure: use azidentity with adapter #6003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/test e2e-azure |
r4f4
force-pushed
the
azure-azid-adapter-2
branch
from
5313974 to
92362fc
Compare
Contributor
Author
Starting with pre-release v0.23.0 of azcore [1] and v0.14.0 of azidentity, they now require golang-1.18 for the use of generics. So we need to either bump our golang version requirement or use earlier pre-releases. [1] https://github.com/Azure/azure-sdk-for-go/releases/tag/sdk%2Fazcore%2Fv0.23.0 |
Contributor
|
/retest |
Contributor
Author
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
needs-rebase
Contributor
|
@r4f4: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
r4f4
force-pushed
the
azure-azid-adapter-2
branch
from
92362fc to
c1eb297
Compare
openshift-merge-robot
removed
the
needs-rebase
Contributor
Author
|
/test e2e-azurestack |
Contributor
Author
|
/test yaml-lint |
Contributor
Author
|
/test e2e-azure-ovn |
openshift-merge-robot
added
the
needs-rebase
r4f4
force-pushed
the
azure-azid-adapter-2
branch
from
dd43eb3 to
7536938
Compare
openshift-merge-robot
removed
the
needs-rebase
Contributor
|
/cc @patrickdillon |
openshift-ci
bot
requested review from
patrickdillon
and removed request for
jstuever
openshift-merge-robot
added
the
needs-rebase
r4f4
force-pushed
the
azure-azid-adapter-2
branch
2 times, most recently
from
ffc3f4c to
08b028e
Compare
openshift-merge-robot
removed
the
needs-rebase
Contributor
Author
|
/test e2e-azurestack |
openshift-merge-robot
added
the
needs-rebase
r4f4
force-pushed
the
azure-azid-adapter-2
branch
from
096be8d to
60e3f4b
Compare
Contributor
|
/hold Revision 8984312 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
Contributor
Author
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Contributor
Contributor
Author
|
/retest-required |
Contributor
r4f4
force-pushed
the
azure-azid-adapter-2
branch
from
8984312 to
984057a
Compare
Contributor
Author
|
Fixed a typo 's/HasPrefix/HasSuffix' |
Microsoft is in the process of upgrading the Azure SDK for Go from V1 to V2. Our clients and authentication are on V1. The V1 authentication utilizes ADAL which will be deprecated June 30, 2022. All V2 clients, except the V2 auth client azidentity, are in beta (azidentity is scheduled to be stable in Q2 2022). [0] These changes remove the dependency on the ADAL API, replace the authentication with azidentity, and use an adapter so the auth will work with V1 clients. [0] https://azure.github.io/azure-sdk/releases/latest/index.html#go https://issues.redhat.com/browse/CORS-1910
Notice that azblob also had to be upgraded to 0.4.1, otherwise we hit the following build issue: vendor/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/zc_blob_lease_client.go:25:16: undefined: to.StringPtr vendor/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/zc_block_blob_client.go:145:20: undefined: to.StringPtr vendor/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/zc_container_lease_client.go:25:16: undefined: to.StringPtr vendor/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/zc_shared_policy_shared_key_credential.go:190:17: undefined: log.EventResponse vendor/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/zm_lease_request_options.go:63:16: undefined: to.StringPtr vendor/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/zm_lease_request_options.go:142:16: undefined: to.StringPtr and newer versions cause pkg/gather/azure/azure.go:224:29: undefined: azblob.NewBlobClientWithSharedKey pkg/gather/azure/azure.go:235:48: unknown field 'MaxRetryRequests' in struct literal of type blob.RetryReaderOptions
r4f4
force-pushed
the
azure-azid-adapter-2
branch
from
984057a to
897b622
Compare
Contributor
Author
|
Rebased on top of master |
Contributor
Author
|
/retest-required |
Contributor
|
/lgtm |
Contributor
|
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
/retest-required |
Contributor
Author
|
/cherry-pick release-4.12 |
|
@r4f4: #6003 failed to apply on top of branch "release-4.12": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/retitle OCPBUGS-4541: Azure: use azidentity with adapter |
openshift-ci
bot
changed the title
Contributor
|
@r4f4: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-4541 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
r4f4
added a commit
to r4f4/installer
that referenced
this pull request
Feb 17, 2023
Fallout from openshift#6003 If we pass `nil` to `azidentity.ParseCertificates`, it assumes the private key isn't encrypted. Let's pipe the password through instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft is in the process of upgrading the Azure SDK for Go from V1 to V2. Our clients and authentication are on V1. The V1 authentication utilizes ADAL which will be deprecated June 30, 2022. All V2 clients, except the V2 auth client azidentity, are in beta (azidentity is scheduled to be stable in Q2 2022). [0]
These changes remove the dependency on the ADAL API, replace the authentication with azidentity, and use an adapter so the auth will work with V1 clients.
[0] https://azure.github.io/azure-sdk/releases/latest/index.html#go
https://issues.redhat.com/browse/CORS-1910