Skip to content

OCPBUGS-7579: azure: fix certificate-based auth with passpharse #6871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 23, 2023
Merged

OCPBUGS-7579: azure: fix certificate-based auth with passpharse #6871

openshift-merge-robot merged 1 commit into from
Feb 23, 2023

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Feb 17, 2023

Fallout from #6003

If we pass nil to azidentity.ParseCertificates, it assumes the private key isn't encrypted. Let's pipe the password through instead.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 17, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 17, 2023

@r4f4: This pull request references Jira Issue OCPBUGS-7653, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fallout from #6003

If we pass nil to azidentity.ParseCertificates, it assumes the private key isn't encrypted. Let's pipe the password through instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 17, 2023
@r4f4
OCPBUGS-7579: azure: fix certificate-based auth with passpharse
78add41 
Fallout from openshift#6003

If we pass `nil` to `azidentity.ParseCertificates`, it assumes the
private key isn't encrypted. Let's pipe the password through instead.
@r4f4 r4f4 force-pushed the azure-certificate-password branch from 1a54f5d to 78add41 Compare February 17, 2023 09:48
@r4f4
Copy link
Contributor Author

r4f4 commented Feb 17, 2023

/retitle OCPBUGS-7579: azure: fix certificate-based auth with passpharse

@openshift-ci openshift-ci bot changed the title OCPBUGS-7653: azure: fix certificate-based auth with passpharse OCPBUGS-7579: azure: fix certificate-based auth with passpharse Feb 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Feb 17, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 17, 2023

@r4f4: This pull request references Jira Issue OCPBUGS-7579, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fallout from #6003

If we pass nil to azidentity.ParseCertificates, it assumes the private key isn't encrypted. Let's pipe the password through instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jhixson74 and mtulio February 17, 2023 09:50
@r4f4
Copy link
Contributor Author

r4f4 commented Feb 17, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 17, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 17, 2023

@r4f4: This pull request references Jira Issue OCPBUGS-7579, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jinyunma February 17, 2023 09:51
@jinyunma
Copy link
Contributor

jinyunma commented Feb 21, 2023 •
edited
Loading

pre-merge test passed, details see bug comments.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 21, 2023
barbacbd
barbacbd reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@rna-afk
Copy link
Contributor

rna-afk commented Feb 22, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rna-afk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023 •
edited
Loading

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-resourcegroup 78add41 link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-azurestack 78add41 link false /test e2e-azurestack
ci/prow/e2e-aws-ovn-workers-rhel8 78add41 link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-vsphere-upi-zones 78add41 link false /test e2e-vsphere-upi-zones
ci/prow/e2e-azure-ovn-shared-vpc 78add41 link false /test e2e-azure-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 22, 2023

/retest-required

Remaining retests: 0 against base HEAD bb7e59b and 2 for PR HEAD 78add41 in total

@openshift-merge-robot openshift-merge-robot merged commit 0a0721d into openshift:master Feb 23, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 23, 2023

@r4f4: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7579 has been moved to the MODIFIED state.

Details

In response to this:

Fallout from #6003

If we pass nil to azidentity.ParseCertificates, it assumes the private key isn't encrypted. Let's pipe the password through instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtulio mtulio Awaiting requested review from mtulio

@jinyunma jinyunma Awaiting requested review from jinyunma

1 more reviewer

@barbacbd barbacbd barbacbd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@barbacbd barbacbd

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@r4f4 @openshift-ci-robot @jinyunma @rna-afk @barbacbd @openshift-merge-robot