Skip to content

azure: move away from ADAL and AD Graph #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Dec 14, 2022
Merged

azure: move away from ADAL and AD Graph #502

openshift-merge-robot merged 3 commits into from
Dec 14, 2022

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Oct 20, 2022

They are being deprecated in December and might be sunset in June 2023.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2022
@2uasimojo
Copy link
Member

2uasimojo commented Oct 20, 2022

@assign @abutcher

Didn't you have ongoing work in this vein? (Carried over from @akhil-rane)

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 20, 2022

I'm making similar changes to the openshift-installer [1]. I marked this as WIP because I'm still investigating why Azure StackCloud authentication is not working through azidentity.

[1] openshift/installer#6003

@openshift-ci openshift-ci bot requested review from 2uasimojo and abutcher October 20, 2022 16:19
@abutcher
Copy link
Member

abutcher commented Oct 20, 2022

Didn't you have ongoing work in this vein?

@2uasimojo This would need to be done as part of https://issues.redhat.com/browse/CCO-235 which is child card of https://issues.redhat.com/browse/CCO-187 but we don't have anything actively ongoing for this.

@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Merging #502 (e709e64) into master (3eb4889) will decrease coverage by 0.10%.
The diff coverage is 8.16%.

❗ Current head e709e64 differs from pull request most recent head a7890ff. Consider uploading reports for the commit a7890ff to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
- Coverage   46.65%   46.54%   -0.11%     
==========================================
  Files          94       94              
  Lines       10040    10068      +28     
==========================================
+ Hits         4684     4686       +2     
- Misses       4799     4824      +25     
- Partials      557      558       +1
Impacted Files Coverage Δ
pkg/azure/clients.go 0.00% <0.00%> (ø)
pkg/azure/minter.go 25.00% <5.40%> (-10.72%) ⬇️
pkg/azure/mock/client_generated.go 100.00% <100.00%> (ø)
pkg/cmd/provisioning/aws/create-iam-roles.go 61.32% <0.00%> (ø)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2022
@r4f4 r4f4 force-pushed the azure-msal-mgraphsdk branch from e709e64 to a7890ff Compare November 22, 2022 15:59
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2022
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 22, 2022

/retitle azure: move away from ADAL and AD Graph

@openshift-ci openshift-ci bot changed the title WIP: azure move away from ADAL and AD Graph azure: move away from ADAL and AD Graph Nov 22, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2022
@abutcher
Copy link
Member

abutcher commented Dec 9, 2022

/test e2e-azure

@abutcher
Copy link
Member

abutcher commented Dec 9, 2022

@jianping-shu I'm not sure that there's anything we need to test here since Mint mode was removed for Azure #433, could you confirm?

@abutcher
Copy link
Member

abutcher commented Dec 9, 2022

Note that the vendoring that exists for azure-sdk-for-go + azidentity will be useful for implementation of openshift/enhancements#1301

@jianping-shu
Copy link

jianping-shu commented Dec 12, 2022 •
edited
Loading

@abutcher Agreed.I think some CCO regression tests on Azure should be fine for this PR. Will do tomorrow.

@jianping-shu
Copy link

jianping-shu commented Dec 13, 2022 •
edited
Loading

Build with Cluster Bot
build #502

(1)Install IPI cluster with built image
https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/ocp-common/job/Flexy-install/164003
Cluster installed successfully
jianpingshu@jshu-mac aws % oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.12.0-0.ci.test-2022-12-13-013707-ci-ln-9h1trgk-latest True False 3h7m Cluster version is 4.12.0-0.ci.test-2022-12-13-013707-ci-ln-9h1trgk-latest

(2)Run some Golang automation CCO cases, all passed
OCP-34470
OCP-45219
OCP-45975
OCP-31768
OCP-50869
OCP-53283

(3)Upgrade to 4.12.0-rc.4 successfully
jianpingshu@jshu-mac openshift-tests-private % oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.12.0-rc.4 True False 11m Cluster version is 4.12.0-rc.4

@jianping-shu
Copy link

jianping-shu commented Dec 13, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 13, 2022
@abutcher
Copy link
Member

abutcher commented Dec 13, 2022

/lgtm

@abutcher
Copy link
Member

abutcher commented Dec 13, 2022

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abutcher
Copy link
Member

abutcher commented Dec 13, 2022 •
edited
Loading

@jeana-redhat @davemulford Seeking docs-approved and px-approved labels for this PR. There is no functional change that would require docs or px changes since we do not currently have Azure mint mode. Please reach out if you have any questions, thanks!

@jeana-redhat
Copy link

jeana-redhat commented Dec 13, 2022

no docs 👍

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Dec 13, 2022
@davemulford
Copy link

davemulford commented Dec 14, 2022

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Dec 14, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 14, 2022

/retest-required

Remaining retests: 0 against base HEAD 37d9187 and 2 for PR HEAD a7890ff in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2022

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6c9af26 into openshift:master Dec 14, 2022
ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025
@openshift-merge-robot
Merge pull request openshift#502 from r4f4/azure-msal-mgraphsdk
c4e43a2 
azure: move away from ADAL and AD Graph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2uasimojo 2uasimojo Awaiting requested review from 2uasimojo

@abutcher abutcher Awaiting requested review from abutcher

Assignees

@abutcher abutcher

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@r4f4 @2uasimojo @abutcher @jianping-shu @jeana-redhat @davemulford @openshift-ci-robot @openshift-merge-robot